Attention is currently required from: msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28846
)
Change subject: Make esme struct shared
......................................................................
Patch Set 15:
(1 comment)
File src/libmsc/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/03cac104_84808772
PS7, Line 895: esme->esme->own_seq_nr = rand();
ESME stands for External Short Message Entities so
it's tied to the SMPP connection. […]
If there's only a user of the struct
emse struct then I'm not sure I'm following the need to move it into an own
library.
If you are moving it to a libray for whatever reason, I'd expect to move/enclose as
much implementation in there, not do it only half way.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 15
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Aug 2022 16:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment