Attention is currently required from: laforge.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-abis/+/39623?usp=email )
Change subject: rtp2trau HR: remove broken TRAU-16k-UL support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Since you originally wrote this TRAU<->RTP code
in 2020 and since you chose back then to implement H […]
Upon further thought, I can
produce a blind (no testing) patch that would bring HR-16k in line with HR-8k, for both DL
and UL. But I am not going to implement unit tests for HR-16k format if there are no
actual BTS that use it. Basically, either have code present (but untested) for HR-16k that
matches the actually used (exercised, tested) HR-8k logic, or remove it - I am fine either
way, and since I am not the project owner here, I'll follow those who are.
I am going to mark the present patch as WIP, then submit an alternative patch that brings
HR-16k in line with HR-8k. Then both patches will be here in Gerrit, and you higher-ups
can decide which one you would rather merge.
Unless someone shows me a counterexample, I am going to *assume* that the 16 kbit/s option
in GSM 08.61 is a paper-only spec that was *never* implemented in physical reality by any
GSM BSS vendor.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/39623?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: If50036c4de9a11db524abffcd87d053878104982
Gerrit-Change-Number: 39623
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 27 Feb 2025 18:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>