Attention is currently required from: jolly, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/32393 )
Change subject: proto_clnt: use osmo_fd_close to close the socket on connection loss
......................................................................
Patch Set 1:
(1 comment)
File src/proto_clnt.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/32393/comment/9614e1ae_eab38680
PS1, Line 94: ofd->fd = 0;
Remove this, afaik osmo_fd_close already marks ofd->fd = -1;
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/32393
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I702b944baf2ebbcc84b6a211e245a4a41627bde6
Gerrit-Change-Number: 32393
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 20 Apr 2023 15:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment