Attention is currently required from: osmith, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 )
Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File src/osmux_input.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/cde3c373_bb47f764 PS2, Line 732: link->name = talloc_asprintf(link, "%p", h);
If there's some deployed software which is hard to update and modify than the issues which makes upd […]
Done
https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/50bfc7ff_8e78031e PS2, Line 777: osmo_talloc_replace_string(link, &link->name, name);
See my other comment in my answer.
Done
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/6ec47527_88b8ee4c PS2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output:
This is not the case though - backward compatibility is when we keep old behavior for old API while […]
Done