Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39984?usp=email )
Change subject: Add function helper hnbgw_decode_ranap_ran_co() ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File src/osmo-hnbgw/context_map_sccp.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39984/comment/1b7a5279_d407390c?us... : PS1, Line 199: static ranap_message *hnbgw_decode_ranap_ran_co(struct msgb *ranap_msg)
I don't get which part of this function is RAN (uplink) specific?
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39984/comment/5f033339_8ce30992?us... : PS1, Line 207: rc = ranap_ran_rx_co_decode(NULL, message, msgb_l2(ranap_msg), msgb_l2len(ranap_msg));
THis function is RAN specific. The CN side is using ranap_cn_rx_co_decode().
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39984/comment/451c9aa6_214636e5?us... : PS1, Line 212: talloc_set_destructor(message, destruct_ranap_ran_rx_co_ies);
destruct_ranap_ran_rx_co_ies() too, which calls RAN specific ranap_ran_rx_co_free().
Done