Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email )
Change subject: sigtran: Make osmo_ss7_asp struct private
......................................................................
Patch Set 3:
(1 comment)
File src/ipa.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645/comment/4ad8b627_a432d…
:
PS3, Line 50: #i
I think naming-wise it's sad that we no longer
have the _internal. […]
I tend to agree, but given that the previous state was
already quite caothic with files already named like this, I preferr to keep on with the
same style, otherwise it becomes even more confusing.
The good point about those headers ow being private is that we can rename them all
together to whatever style we want in the future easily.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I5839b4dd04468af20d1836386dcc722e7a83ac5f
Gerrit-Change-Number: 38645
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 07 Nov 2024 12:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>