Attention is currently required from: jolly, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email )
Change subject: osmo-bts-virtual: Port over to osmo_io
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bts-virtual/scheduler_virtbts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/09280084_61ee0f4f
PS2, Line 105: else if (rc == 0)
If the socket dies, not handling of rc <= 0 will result in an infinite loop of read events. […]
This is not `read()`, but `send()` code path. The return value is either the number of bytes sent, or -1. AFAIU, checking against 0 makes no sense (even before this patch), so this is why this block is being dropped?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c
Gerrit-Change-Number: 36317
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: jolly
andreas@eversberg.eu
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 19 Mar 2024 11:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
andreas@eversberg.eu
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment