Attention is currently required from: fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/28278 )
Change subject: cards: populate ADM1 key reference member
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/28278/comment/fe27086b_c8765982
PS1, Line 9: speficy
specify?
Done
https://gerrit.osmocom.org/c/pysim/+/28278/comment/21a22aa0_e107b0fa
PS1, Line 10: inherets
inherits
Done
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/28278/comment/ad7e4942_0994de7c
PS1, Line 350: print("NOW")
This looks like a debugging leftover that should have
been removed.
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/28278
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I96af395b1832f4462a6043cca3bb3812fddac612
Gerrit-Change-Number: 28278
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Jun 2022 07:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment