Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email )
Change subject: TRAU frame output EDATA: set sync pattern bits
......................................................................
Patch Set 2:
(2 comments)
File src/trau/trau_frame.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/38323/comment/6f142a84_79097287… :
PS1, Line 680: memset(trau_bits, 0, 16);
This memset is not 0-initialization, it is the sync
pattern. See the frame structure table in TS 48. […]
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/38323/comment/c6e3664e_f8540e81… :
PS1, Line 681: trau_bits[17] = 1;
Oops, I was setting the wrong bit - good catch! Fixed
in the new patch revision.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69
Gerrit-Change-Number: 38323
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Oct 2024 22:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>