Attention is currently required from: laforge.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415?usp=email )
Change subject: sip: tweak failure reporting for SIP messages
......................................................................
Patch Set 1:
(1 comment)
File sip/SIP_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415/comment/9a2a7eea_907c…
PS1, Line 195: og("FAIL: expected SIP message ", sip_expect);
: setverdict(fail, "Received unexpected SIP message");
I don't really like this kind of duplication. […]
IIRC the reason why i got into the behavior to log separately is that message dumps
in verdicts aren't formatted by ttcn3_logformat; the verdict string doesn't seem
to be intended for long dumps. So I like to get a short crunchy reason in the verdict, and
look at the dumps in the normal log instead...
I'm using f_shutdown() now, but I am keeping the separate log, ok?
BTW with f_shutdown(), I wouldn't know how to append a message dump.
With log("bla ", msg) it works, but with f_shutdown(..., fail, "bla "
& msg) it doesn't.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id48016657ebb83953fe74f65332f318edf8f75e6
Gerrit-Change-Number: 34415
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 15 Sep 2023 02:49:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment