Attention is currently required from: laforge.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415?usp=email )
Change subject: sip: tweak failure reporting for SIP messages ......................................................................
Patch Set 1:
(1 comment)
File sip/SIP_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415/comment/9a2a7eea_907cb... PS1, Line 195: og("FAIL: expected SIP message ", sip_expect); : setverdict(fail, "Received unexpected SIP message");
I don't really like this kind of duplication. […]
IIRC the reason why i got into the behavior to log separately is that message dumps in verdicts aren't formatted by ttcn3_logformat; the verdict string doesn't seem to be intended for long dumps. So I like to get a short crunchy reason in the verdict, and look at the dumps in the normal log instead...
I'm using f_shutdown() now, but I am keeping the separate log, ok?
BTW with f_shutdown(), I wouldn't know how to append a message dump. With log("bla ", msg) it works, but with f_shutdown(..., fail, "bla " & msg) it doesn't.