Attention is currently required from: neels, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337 )
Change subject: separate pfcp_queue_timer_cb() in req and resp
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/libosmo-pfcp/pfcp_endpoint.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337/comment/da77bffa_9916e1c9
PS1, Line 285: } else {
i don't see a reason to use different timer names.
[…]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ic8ab71f5efd4cf669689a0b075f9a52ce66bdd5d
Gerrit-Change-Number: 28337
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jul 2022 12:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment