Attention is currently required from: daniel, msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31172 )
Change subject: Add osmo_sockaddr_size() to return the size of the variant used
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/core/socket.h:
https://gerrit.osmocom.org/c/libosmocore/+/31172/comment/2a1d4415_d0f74619
PS1, Line 42: {
I was about to disagree with Max, but since sendto() can be used with NULL and 0 for addr/addr_len i […]
"I was about to disagree with Max, but since sendto() can be used with NULL and 0 for addr/addr_len it might make sense to return 0 if addr is NULL."
can you share some reference about where did you find this?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31172
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I952b6bb752441fe019fc18f89bce4bbfbe58994a
Gerrit-Change-Number: 31172
Gerrit-PatchSet: 2
Gerrit-Owner: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev
msuraev@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Attention: msuraev
msuraev@sysmocom.de
Gerrit-Comment-Date: Tue, 21 Feb 2023 17:17:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: daniel
dwillmann@sysmocom.de
Comment-In-Reply-To: msuraev
msuraev@sysmocom.de
Gerrit-MessageType: comment