5 Feb
2026
5 Feb
'26
4:38 p.m.
Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email )
Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ......................................................................
Patch Set 1:
(2 comments)
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064/comment/f7812d17_19c120... : PS1, Line 233: struct osmo_ss7_asp *asp; I would also set it to NULL
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064/comment/6ec7c0a0_357783... : PS1, Line 247: return asp; How do you return back a NULL in case non of the given asp is valid?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232
Gerrit-Change-Number: 42064
Gerrit-PatchSet: 1
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Thu, 05 Feb 2026 16:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No