[L] Change in libosmocore[master]: ASCI: Add message definition and encoding according to 3GPP TS 48.008

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32932 ) Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ...................................................................... Patch Set 5: (1 comment) File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/bbe06fee_5e6ec682 PS5, Line 386: struct sockaddr_storage *aoip_transport_layer; why did you change this to be a pointer? it doesn't match with most structures here and in general in other messages being stored in the same struct. I think having to provide an extra pointer is more cumbersome, because you then need to keep around an external struct either temporarily in the stack or somehow heap allocated and remember to free it afterwards. so in summary, I think this should be moved to be sockaddr_storage. Maybe change it to a struct osmo_sockaddr if at all. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f Gerrit-Change-Number: 32932 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 24 May 2023 14:24:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment