Attention is currently required from: jolly.

View Change

1 comment:

• File include/osmocom/gsm/gsm0808.h:

  • Patch Set #5, Line 386: struct sockaddr_storage *aoip_transport_layer;

    why did you change this to be a pointer? it doesn't match with most structures here and in general in other messages being stored in the same struct.
    I think having to provide an extra pointer is more cumbersome, because you then need to keep around an external struct either temporarily in the stack or somehow heap allocated and remember to free it afterwards.

    so in summary, I think this should be moved to be sockaddr_storage. Maybe change it to a struct osmo_sockaddr if at all.

To view, visit change 32932. To unsubscribe, or for help writing mail filters, visit settings.