Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32932 )
Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ......................................................................
Patch Set 5:
(1 comment)
File include/osmocom/gsm/gsm0808.h:
https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/bbe06fee_5e6ec682 PS5, Line 386: struct sockaddr_storage *aoip_transport_layer; why did you change this to be a pointer? it doesn't match with most structures here and in general in other messages being stored in the same struct. I think having to provide an extra pointer is more cumbersome, because you then need to keep around an external struct either temporarily in the stack or somehow heap allocated and remember to free it afterwards.
so in summary, I think this should be moved to be sockaddr_storage. Maybe change it to a struct osmo_sockaddr if at all.