Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/32085 )
Change subject: msc_main: close SMS db on startup error
......................................................................
Patch Set 2:
(2 comments)
File src/osmo-msc/msc_main.c:
https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/85b7f54e_eff28ee8
PS2, Line 745: sms_queue_start
BTW, can we move the DB init down below? Not saying this must be done, but I think this
would simplify the flow a bit (less gotos).
https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/c58e4fec_c2110e14
PS2, Line 832: error_close_sms_db
AFAICS, `db_fini()` can be called at any time, even if the database is not initialized.
Thus this additional label can be avoided.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/32085
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9bb799048db5fcdb2a2520107bd75d5f7a865459
Gerrit-Change-Number: 32085
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Apr 2023 16:01:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment