15 Mar
2023
15 Mar
'23
1:03 a.m.
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 )
Change subject: tests/llc: local libs must be first in *_LDADD ......................................................................
Patch Set 1:
(1 comment)
File tests/llc/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31774/comment/4eb3e716_41e41c82 PS1, Line 36: $(LIBOSMOCORE_LIBS) \
These should actually be swapped too actually, so that dependency chain is correct: first LIBOSMOGSM […]
As I explained in a similar patch in response to your similar comment, this is not as important as having the local libraries listed first. So I am not going to swap external libs in this patch.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31774
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: If5299340ad72407d01e728febf356a07a1d99681
Gerrit-Change-Number: 31774
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 14 Mar 2023 14:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment