Attention is currently required from: osmith, neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 )
Change subject: Check VTY config against features reported by BTS ......................................................................
Patch Set 4:
(4 comments)
File src/osmo-bsc/bts_trx.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/9b614c3c_433c3e8e PS4, Line 343: struct bitvec *ft const
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/c3a72264_5b484990 PS4, Line 355: if (!osmo_bts_has_feature(ft, BTS_FEAT_VAMOS)) { Not sure this check makes sense here. I would expect that all lchans to have 'vamos.enabled == false' at start up. Neels can definitely say more here.
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/408917e9_1d766d4c PS4, Line 319: struct gsm_bts *bts const
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/1ebe2d03_0afb89a9 PS4, Line 342: struct gsm_bts *bts const