20 Mar
2023
20 Mar
'23
9:39 p.m.
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31982 )
Change subject: pcu_sock.c: Call osmo_fd_unregister() before closing and changing listen_bfd->fd ......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31982/comment/ace7e45b_8f0d6b08 PS1, Line 1015: close(bfd->fd); Also if possible set bfd->fd to -1. This is the reason I didn't fix this one yet, because I didn't spot it, didn't show up when grepping for -1 and unregister.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31982
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I48e0411c4cba9897bc04865d22d8f68ed4fe87a2
Gerrit-Change-Number: 31982
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 20 Mar 2023 10:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment