15 Feb
2023
15 Feb
'23
8:26 p.m.
Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31303 )
Change subject: Includes: Add gprs/rlc related enums ......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
File include/osmocom/gprs/gprs_rlc.h:
https://gerrit.osmocom.org/c/libosmocore/+/31303/comment/4c03bb4d_58b50393 PS1, Line 47: enum gprs_rlc_par {
This looks not really related to TS 44. […]
Since you wrote to put it either in libosmo-abis or libosmocore I decided to put them here as it's about about RLC, too. Would you prefer I put them in `libosmo-abis/include/osmocom/ipaccess.h` (I suppose with the prefix `OSMO_ABIS`?)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1ec2e52ad7fa625c08fe9df04d4a4f5323bf609c
Gerrit-Change-Number: 31303
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 15 Feb 2023 19:26:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment