[M] Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email ) Change subject: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677/comment/6541fa66_5e7a… PS1, Line 2263: f_ms_tx_TsTrxBtsNum(ms)); can we use cached `nr` here and below? or is it expected to change, so we have to use `f_ms_tx_TsTrxBtsNum()`? I see you're using cached `nr` in PCUIF DATA.ind templates. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677/comment/f9f93e37_148a… PS1, Line 2329: f_ms_tx_TsTrxBtsNum(ms)); likewise, can we use `nr` here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08921132de863404485581dfa439a54f109b0078 Gerrit-Change-Number: 37677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 16:27:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment