Attention is currently required from: neels, nt2mku.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )
Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is
supported
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/3a0b2db8_2093e9f2
PS2, Line 7: mobile-terminating setup requests
Please note that `gsm48_encode_bearer_cap()` is also
used by osmocom-bb, so this change also affects […]
Done
File src/gsm/gsm48_ie.c:
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/c298dc04_2edf21f0
PS2, Line 330: /* if we have only one speech version, which is FR, skip octet 3a */
Let's add a spec. reference here: […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b
Gerrit-Change-Number: 36784
Gerrit-PatchSet: 5
Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Comment-Date: Sat, 25 May 2024 07:15:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment