Attention is currently required from: fixeria, pespin, lynxis lazus.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/29703
)
Change subject: abis_rsl: show full request reference in log
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29703/comment/a029d499_9f39eaf1
PS1, Line 1915: LOG_BTS(bts, DRSL, LOGL_INFO, "CHAN RQD: reason: %s (ra=0x%02x,
t1=%d, t3=%d, t2=%d, neci=0x%02x, chreq_reason=0x%02x)\n",
Actually, from the end user perspective, it probably
makes sense to convert T1/T2/T3 into TDMA Fn va […]
The order T1, T2, T3 is
intentional. That is the order in which the numbers are stored and also the order in which
wireshark will display the values. When debuging it is easier when one does not have to
convert between different display variants.
The fn is displayed at later log lines as well, no need to display it here once more. (it
is important to see T1, T2, T3 since wireshark won't always do the conversion.)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/29703
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I78499b49ae176b736e384e193fadc0bdd669dffa
Gerrit-Change-Number: 29703
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 14 Oct 2022 14:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment