arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31595 )
Change subject: osmo_wqueue_init(): Fix parameter type ......................................................................
osmo_wqueue_init(): Fix parameter type
The field `max_length` of `struct osmo_wqueue` is of type `unsigned int`; the function body doesn't show any reason why we should accept `int` as a parameter
Change-Id: I6c9295750e1755bf1d80f3a3b32efc2aefb11a57 --- M include/osmocom/core/write_queue.h M src/core/write_queue.c 2 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/31595/1
diff --git a/include/osmocom/core/write_queue.h b/include/osmocom/core/write_queue.h index 6cb0a6b..86f2ca9 100644 --- a/include/osmocom/core/write_queue.h +++ b/include/osmocom/core/write_queue.h @@ -46,7 +46,7 @@ int (*except_cb)(struct osmo_fd *fd); };
-void osmo_wqueue_init(struct osmo_wqueue *queue, int max_length); +void osmo_wqueue_init(struct osmo_wqueue *queue, unsigned int max_length); void osmo_wqueue_clear(struct osmo_wqueue *queue); int osmo_wqueue_enqueue(struct osmo_wqueue *queue, struct msgb *data); int osmo_wqueue_enqueue_quiet(struct osmo_wqueue *queue, struct msgb *data); diff --git a/src/core/write_queue.c b/src/core/write_queue.c index 884cebd..2c5a85b 100644 --- a/src/core/write_queue.c +++ b/src/core/write_queue.c @@ -88,7 +88,7 @@ * \param[in] queue Write queue to operate on * \param[in] max_length Maximum length of write queue */ -void osmo_wqueue_init(struct osmo_wqueue *queue, int max_length) +void osmo_wqueue_init(struct osmo_wqueue *queue, unsigned int max_length) { queue->max_length = max_length; queue->current_length = 0;