Attention is currently required from: laforge, daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31356 )
Change subject: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/31356/comment/78c79e65_f400ee34
PS2, Line 9: Currently there's a big mess where include dir osmocom/gprs/ is used by
: both libosmogsm and libosmogb.
I don't think that by itself constitues any mess.
[…]
Well it's a mess every time I need to release a new version of libosmocore,
since I have to first remember and handle the specific case of gprs/ dir being libosmogb
(LIBVERSION), and furthermore trying to find out that actually some headers there are part
of libosmogsm. And yes, I can say that before I submitted these patches I wasn't even
aware of that mess, so I may have modified LIBVERSION of libosmogsm and libosmogb in the
wrong way on some ocassion due to that fact, because this current status is totally
unexpected IMHO.
https://gerrit.osmocom.org/c/libosmocore/+/31356/comment/b93c6d68_159a9a08
PS2, Line 30: can eventually get rid of them.
and eventuall break building old applications, which
we generally try not to, unless it's really imp […]
Then keep the dummy headers
for as long as you wish (eg whenever we find in the long future that anyway we have to
break the ABI to solve some problem).
But even if we keep them forever, imho this patch already fixes a situation which I'm
sure provoked problems in the past, and which I'm sure will provoke more in the
future.
This way all new development happens under osmocom/gb/ and osmocom/gsm/ which is way
clearer, and avoid dependency mess like it happened.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31356
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I70cc21bf25a7081070738abacb409ed19094c3b2
Gerrit-Change-Number: 31356
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 10:21:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment