Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38457?usp=email )
Change subject: ggsn: Support announcing APN MTU over PCO ......................................................................
Patch Set 4:
(4 comments)
File ggsn/ggsn.h:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/f7c1de3d_52d75ed8?usp... : PS4, Line 36: #define IPV6_HDR_MAX_SIZE 40 /* Assume no extension headers in general... */ IPV6_HDR_MAX_SIZE < IPV4_HDR_MAX_SIZE, is this correct?
File ggsn/ggsn_vty.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/7ab6b54d_b90aa385?usp... : PS4, Line 425: "mtu (<0-1464>|default)", maybe use MAX_POSSIBLE_APN_MTU instead of 1464 here?
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/91aa4727_3d3dda0d?usp... : PS4, Line 428: "Default value of the MTU of the APN (1420)") maybe use MAX_DESIRED_APN_MTU instead of 1420 here?
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/814a6aba_324df9f5?usp... : PS4, Line 708: vty_out(vty, " mtu %" PRIu16 "%s", apn->cfg.mtu, VTY_NEWLINE); skip if == default?