21 Oct
2024
21 Oct
'24
1:49 p.m.
Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457?usp=email )
Change subject: ggsn: Support announcing APN MTU over PCO
......................................................................
Patch Set 4:
(4 comments)
File ggsn/ggsn.h:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/f7c1de3d_52d75ed8?us… :
PS4, Line 36: #define IPV6_HDR_MAX_SIZE 40 /* Assume no extension headers in general...
*/
IPV6_HDR_MAX_SIZE < IPV4_HDR_MAX_SIZE, is this correct?
File ggsn/ggsn_vty.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/7ab6b54d_b90aa385?us… :
PS4, Line 425: "mtu (<0-1464>|default)",
maybe use MAX_POSSIBLE_APN_MTU instead of 1464 here?
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/91aa4727_3d3dda0d?us… :
PS4, Line 428: "Default value of the MTU of the APN (1420)")
maybe use MAX_DESIRED_APN_MTU instead of 1420 here?
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/814a6aba_324df9f5?us… :
PS4, Line 708: vty_out(vty, " mtu %" PRIu16 "%s", apn->cfg.mtu,
VTY_NEWLINE);
skip if == default?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38457?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I8532acfffadda9e83962b30e4f6b17eb8b3362ac
Gerrit-Change-Number: 38457
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Oct 2024 11:49:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No