Attention is currently required from: laforge.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38444?usp=email )
Change subject: GTP: CreatePDPContext: only use IMEISV IE when IMEISV is known ......................................................................
Patch Set 1:
(1 comment)
File src/sgsn/sgsn_libgtp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/38444/comment/c3f83f58_332710fe?usp... : PS1, Line 303: if (mmctx->imei[0] != 0x00) {
a 0 digit would be 0x30, not 0x00. But yes, '\0' is more clear.
Would be strlen() more clear?
The imei handling in general could also receive some love. Since mm->imei contains imei+checksum digits+nullbyte But we don't have the Software Version somewhere.