Attention is currently required from: neels.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/36989?usp=email )
Change subject: silence error message for N-STATE prim
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/osmo_bsc_sigtran.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/36989/comment/f796e198_031adbf1
PS1, Line 367: operation %s on primitive
there is no "operation %s on primitive", the old error message and this new
message are both wrong. A primitive is a piece of data; we do not operate on it. SIGTRAN
also doesn't operate on privmitives. Also, SIGTRAN is completely wrong here as the
SCCP user has no knowledge whatsoever of the underlying transport encoding.
"Ignoring %s primitive received on SCCP-User-SAP" would be a correct phrasing.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/36989?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic353840a7b2e32c54c2732f58836776a5eddb220
Gerrit-Change-Number: 36989
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Jun 2024 14:33:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment