20 Dec
2022
20 Dec
'22
4:52 p.m.
Attention is currently required from: arehbein, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 )
Change subject: libosmocore: Transition to use of 'telnet_init_default' ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File src/vty/telnet_interface.c:
https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/4e471563_8cd037a3 PS3, Line 110: int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port) You missed calling _telnet_init_dynif() in here instead of duplicating code.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454
Gerrit-Change-Number: 30703
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Tue, 20 Dec 2022 15:52:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment