Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/28874 )
Change subject: trxcon: allow populating global SACCH cache via L1CTL
......................................................................
Patch Set 2:
(2 comments)
File src/host/trxcon/src/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28874/comment/997a23e7_91a1e721
PS1, Line 655: if (!traffic && req.link_id == 0x40)
can you describe this 0x40? I'm sure we may have
some sort of defines for it?
I added a comment: 0x40 means SACCH. Unfortunately
there is no macro in libosmocore...
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28874/comment/1045c3cc_b52c168d
PS1, Line 90: LOGPFSML(fi, LOGL_ERROR, "Unexpected link_id=%u\n",
req->link_id);
probably want to print as hex
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28874
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I0f467fc07cf844cc73465f235b36ba7d00788c9f
Gerrit-Change-Number: 28874
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Aug 2022 08:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment