Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/39952?usp=email )
Change subject: SMS-over-GSUP: send network-originated MT-forwardSM-Err ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/39952/comment/81a82413_5a1ae229?usp=... : PS1, Line 1332: rate_ctr_inc(rate_ctr_group_get_ctr(net->msc_ctrs, MSC_CTR_SMS_DELIVERED));
I'm not saying it's related to this patch, just flagged it in case you want to take the chance to fi […]
I would love to improve SMS related counters, specifically for the SMS-over-GSUP mode. But given their current rather unfortunate state (for instance, the counter name suggests completed delivery, but its description says "delivery attempts"), this would be a significant effort. I asked the customer if they're interested in improving this.