21 Sep
2022
21 Sep
'22
6:57 p.m.
Attention is currently required from: neels, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/29398 )
Change subject: llc: add missing LLE <-> (RLC/MAC,BSSGP) primitives
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File include/osmocom/gprs/llc/llc.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/29398/comment/d9d6a917_c022668f
PS2, Line 58: /* LLE <-> RLC/MAC (MS side) */
the eNUM already contains members for primitives of
two multiple different SAPs, so it is logical to […]
I see no significant benefits
of having separate enums. Currently there are no known users of this library (other than
my WIP code), and there have been no stable release yet, so later we can split this enum
if you think it makes sense.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29398
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I10bb63220585424584185ce2bde2d9f8fd0d8342
Gerrit-Change-Number: 29398
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Sep 2022 16:57:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment