[S] Change in ...osmo-epdg[master]: s2b: answer echo requests

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email ) Change subject: s2b: answer echo requests ...................................................................... Patch Set 1: (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900/comment/2610c1aa_b5ea… : PS1, Line 520: IEs = [#v2_recovery{restart_counter = RCnt}], agreeing with pespin. And indeed it's supposed to increment at every local restart. So either store it in a file (like osmo-ggsn/sgsn does, AFAIR) or use a timestamp based hack as suggested. However, the timestamp must not be the local time when sending the echo, but a timestamp that's once obtained when the process starts and then used for all RestartCounter fields during the runtime of the program (basically as long as beam runs in the erlang case). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3c470bd89b9811ba269b53eb400ffc21db4fba3a Gerrit-Change-Number: 37900 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 22 May 2025 04:39:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>