Attention is currently required from: daniel, jolly, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email )
Change subject: osmo_stream_cli_write(): fix double-free of msgb
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
I guess it may be that we actually want to return at
the end of that 'ret < 0' clause? not sure if r […]
Done. I discussed
with @andreas@eversberg.eu and according to him calling `osmo_fd_write_disable()` after
`osmo_stream_cli_reconnect()` makes no sense because the later calls
`osmo_stream_cli_close()`, which then unregisters the `fd`.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I954678acd90593e5311d22a10033c7741f280be3
Gerrit-Change-Number: 36159
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2024 10:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment