laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33783 )
Change subject: proto_srv: Fix file descriptor and memory leak in error paths ......................................................................
proto_srv: Fix file descriptor and memory leak in error paths
Fixes: CID#307517 Change-Id: I44e349eee5b0b54843762db8cadd6b9b1758faa4 --- M src/proto_srv.c 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/83/33783/1
diff --git a/src/proto_srv.c b/src/proto_srv.c index d6d3d17..2b85ac6 100644 --- a/src/proto_srv.c +++ b/src/proto_srv.c @@ -185,6 +185,7 @@ conn = talloc_zero(srv->ctx, struct osmo_e1dp_server_conn); if (!conn) { LOGP(DE1D, LOGL_ERROR, "Failed to create incoming connection.\n"); + close(rc); return -1; }
@@ -197,6 +198,8 @@
if (osmo_fd_register(&conn->fd) != 0) { LOGP(DE1D, LOGL_ERROR, "Failed to register incoming fd.\n"); + close(conn->fd.fd); + talloc_free(conn); return -1; }