Attention is currently required from: daniel, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34526?usp=email )
Change subject: meas_feed: Use osmo_io instead of write queue ......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
Patchset:
PS4:
I think you are totally mixing 2 things in this patch: […]
I changed it because otherwise the code would be misleading, since we're not using write queues anymore. Hence it's part of the switch from using a write queue to using osmo_io
File src/osmo-bsc/meas_feed.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/51bc3cd8_a4f0730e PS4, Line 117: if (g_mfs.io_fd == NULL) /* TODO: Check if this is the right condition to check if io_fd is initialized */
TODOs
ah yeah. Pushing an update to the patch unset the WIP flag that I originally pushed the patch with. It wasn't meant to be active in its current state