Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/34325?usp=email )
Change subject: pySim-shell: fix commandline option -a (verify_adm)
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
(FYI: We had a similar problem before, see also:
Ic87e1bff221b10d33d36da32b589e2737f6ca9cd)
well, all this tells me is that there is
a lack of test coverage. We should add something to our test scripts to make sure we test
that command line option during the pysim tester execution.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34325?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic1e54d0e9e722d64b3fbeb044134044d47946f7c
Gerrit-Change-Number: 34325
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Sep 2023 13:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment