Attention is currently required from: neels.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27903 )
Change subject: emerg call deny: do not dispatch dtap
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/gsm_04_08_rr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27903/comment/9ddbe8b4_dbdb0ba1
PS1, Line 1077: /* fall through */
I see no change here: 'break' generally moves the execution flow out of the switch
statement (unless it's part of an inner switch statement or a loop). Neither I see
inner switch statements here, nor any loops. So if we break, we don't fall through. Am
I missing something?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27903
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I065953f0380e142824ba30a842c86f9c598f89fe
Gerrit-Change-Number: 27903
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Apr 2022 23:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment