Attention is currently required from: jtavares.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-remsim/+/30139 )
Change subject: bankd: Add GSMTAP functionality for SIM traffic
......................................................................
Patch Set 3:
(3 comments)
File src/bankd/gsmtap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-998):
https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/91c238cd_aad7b538
PS3, Line 81: iov[cnt].iov_base = (void*)&gh;
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-998):
https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/0a38ddde_8332191b
PS3, Line 86: iov[cnt].iov_base = (void*)mdm_tpdu;
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-998):
https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/afefbcc5_a4afffcf
PS3, Line 92: iov[cnt].iov_base = (void*)sim_tpdu;
"(foo*)" should be "(foo *)"
--
To view, visit
https://gerrit.osmocom.org/c/osmo-remsim/+/30139
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08
Gerrit-Change-Number: 30139
Gerrit-PatchSet: 3
Gerrit-Owner: jtavares <jtavares(a)kvh.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jtavares <jtavares(a)kvh.com>
Gerrit-Comment-Date: Mon, 14 Nov 2022 22:14:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment