Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27528 )
Change subject: System Information Type 3: allow updating T3212 at run-time
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/system_information.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27528/comment/858ebf87_bcf04039
PS2, Line 968: bts->si_common.chan_desc.t3212 =
osmo_tdef_get(bts->network->T_defs, 3212, OSMO_TDEF_CUSTOM, 0);
I'm asking because I see it's in
"si_common".
Ah, I see. Perhaps it should be renamed to
'si_paras'. As far as I can see, it does contain very specific members like
si5_neigh_list and si2quater_neigh_list. Can be done in a separate patch, here I am just
fixing the field not being updated properly.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27528
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iee291623c2825505eeb5175adcedadfe35375b9e
Gerrit-Change-Number: 27528
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Mar 2022 22:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment