- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: logging: log to stdout when logging is not initialized
by dexter 19 Jan '22

19 Jan '22

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... logging: log to stdout when logging is not initialized When the logging framework is not initialized we get an error: "ERROR: osmo_log_info == NULL! You must call log_init() before using logging in ..." There are sometimes situations where some code tries to log before logging was initialied. This is a problem because the actual log line with the debug info we need is covered up by the error message from the logging framework. Lets introduce a fallback logging function that is called when the the logging framework is not available. This function can just use printf. Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 --- M include/osmocom/core/logging.h M src/logging.c 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26950/1 diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 4a34c7d..fea6b56 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -56,6 +56,10 @@ #ifndef LIBOSMOCORE_NO_LOGGING #define LOGPC(ss, level, fmt, args...) \ do { \ + if (!log_initialized()) { \ + logp_stub(__FILE__, __LINE__, 1, fmt, ##args); \ + break; \ + } \ if (log_check_level(ss, level)) \ logp2(ss, level, __FILE__, __LINE__, 1, fmt, ##args); \ } while(0) @@ -94,6 +98,13 @@ #ifndef LIBOSMOCORE_NO_LOGGING #define LOGPSRCC(ss, level, caller_file, caller_line, cont, fmt, args...) \ do { \ + if (!log_initialized()) { \ + if (caller_file) \ + logp_stub(caller_file, caller_line, cont, fmt, ##args); \ + else \ + logp_stub(__FILE__, __LINE__, cont, fmt, ##args); \ + break; \ + } \ if (log_check_level(ss, level)) {\ if (caller_file) \ logp2(ss, level, caller_file, caller_line, cont, fmt, ##args); \ @@ -380,7 +391,9 @@ void logp2(int subsys, unsigned int level, const char *file, int line, int cont, const char *format, ...) __attribute__ ((format (printf, 6, 7))); +void logp_stub(const char *file, int line, int cont, const char *format, ...); int log_init(const struct log_info *inf, void *talloc_ctx); +int log_initialized(void); void log_fini(void); int log_check_level(int subsys, unsigned int level); diff --git a/src/logging.c b/src/logging.c index 9d2a065..03b06a8 100644 --- a/src/logging.c +++ b/src/logging.c @@ -312,6 +312,14 @@ } } +/* Check whether the logging framework is initialized (osmo_log_info exists) */ +int log_initialized(void) +{ + if (!osmo_log_info) + return 0; + return 1; +} + /* special magic for negative (library-internal) log subsystem numbers */ static int subsys_lib2index(int subsys) { @@ -748,6 +756,18 @@ TRACE(LIBOSMOCORE_LOG_DONE()); } +/* This logging function is used as a fallback when the logging framework is + * not is not properly initialized. */ +void logp_stub(const char *file, int line, int cont, const char *format, ...) +{ + va_list ap; + if (!cont) + printf("%s:%d ", file, line); + va_start(ap, format); + vprintf(format, ap); + va_end(ap); +} + /*! Register a new log target with the logging core * \param[in] target Log target to be registered */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Build failure of network:osmocom:nightly/osmo-sip-connector in openSUSE_Factory_ARM/armv7l
by OBS Notification 19 Jan '22

19 Jan '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-sip-connector failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 50s] [175/192] cumulate glib2-tools-2.70.2-1.2 [ 50s] [176/192] cumulate post-build-checks-84.87+git20210304.df696a0-1.2 [ 50s] [177/192] cumulate pam-1.5.2-5.3 [ 50s] [178/192] cumulate gcc11-11.2.1+git1173-1.3 [ 50s] [179/192] cumulate libstdc++-devel-11-4.3 [ 50s] [180/192] cumulate gcc-11-4.3 [ 50s] [181/192] cumulate libopenssl-1_1-devel-1.1.1m-1.3 [ 50s] [182/192] cumulate pam_unix-1.5.2-5.3 [ 50s] [183/192] cumulate shadow-4.11.1-1.1 [ 50s] [184/192] cumulate util-linux-2.37.2-2.3 [ 50s] [185/192] cumulate gcc-PIE-11-4.3 [ 50s] [186/192] cumulate pcre-devel-8.45-1.3 [ 50s] [187/192] cumulate pcre2-devel-10.39-1.3 [ 50s] [188/192] cumulate rpm-build-4.17.0-2.4 [ 50s] [189/192] cumulate libselinux-devel-3.3-1.3 [ 50s] [190/192] cumulate libmount-devel-2.37.2-2.3 [ 50s] [191/192] cumulate glib2-devel-2.70.2-1.2 [ 50s] [192/192] cumulate sofia-sip-devel-1.12.11+20110422-2.40 [ 50s] now installing cumulated packages [ 50s] error: .init_b_cache/bash-sh.rpm: signature region trailer: BAD, tag 0 type 0 offset 0 count 0 [ 50s] error: .init_b_cache/bash-sh.rpm cannot be installed [ 50s] exit ... [ 50s] ### VM INTERACTION START ### [ 53s] [ 8.808992][ T390] sysrq: Power Off [ 53s] [ 8.826295][ T7] reboot: Power down [ 53s] ### VM INTERACTION END ### [ 53s] [ 53s] obs-arm-11 failed "build osmo-sip-connector.spec" at Wed Jan 19 00:58:36 UTC 2022. [ 53s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Build failure of network:osmocom:nightly/osmo-hnbgw in openSUSE_Factory_ARM/armv7l
by OBS Notification 19 Jan '22

19 Jan '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnbgw Last lines of build log: [ 39s] [166/184] cumulate libosmogb12-1.6.0.43.663e.202201180026-1.1 [ 39s] [167/184] cumulate post-build-checks-84.87+git20210304.df696a0-1.2 [ 39s] [168/184] cumulate pam-1.5.2-5.3 [ 39s] [169/184] cumulate gcc11-11.2.1+git1173-1.3 [ 39s] [170/184] cumulate gcc-11-4.3 [ 39s] [171/184] cumulate libopenssl-1_1-devel-1.1.1m-1.3 [ 39s] [172/184] cumulate libosmonetif-devel-1.1.0.11.2687.202201180026-1.1 [ 39s] [173/184] cumulate libosmoabis-devel-1.2.0.3.f5f3.202201180026-1.1 [ 39s] [174/184] cumulate libosmoctrl-devel-1.6.0.43.663e.202201180026-1.1 [ 39s] [175/184] cumulate libosmogb-devel-1.6.0.43.663e.202201180026-1.1 [ 39s] [176/184] cumulate pam_unix-1.5.2-5.3 [ 39s] [177/184] cumulate libosmo-sigtran7-1.5.0.4.853c.202201180026-1.1 [ 39s] [178/184] cumulate shadow-4.11.1-1.1 [ 39s] [179/184] cumulate util-linux-2.37.2-2.3 [ 39s] [180/184] cumulate gcc-PIE-11-4.3 [ 39s] [181/184] cumulate libosmo-sigtran-devel-1.5.0.4.853c.202201180026-1.1 [ 39s] [182/184] cumulate libosmo-ranap5-1.2.0.14.fb58.202201180026-1.1 [ 39s] [183/184] cumulate rpm-build-4.17.0-2.4 [ 39s] [184/184] cumulate libosmo-ranap-devel-1.2.0.14.fb58.202201180026-1.1 [ 39s] now installing cumulated packages [ 40s] error: error reading from file .init_b_cache/filesystem.rpm [ 40s] exit ... [ 40s] ### VM INTERACTION START ### [ 43s] [ 8.580077][ T391] sysrq: Power Off [ 43s] [ 8.580681][ T7] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] obs-arm-11 failed "build osmo-hnbgw.spec" at Tue Jan 18 23:58:45 UTC 2022. [ 43s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-e1-hardware[master]: icE1usb doc: Add pictures of front and back side
by laforge 18 Jan '22

18 Jan '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 ) Change subject: icE1usb doc: Add pictures of front and back side ...................................................................... icE1usb doc: Add pictures of front and back side Closes: OS#5406 Change-Id: Ifc382c762119b397dd9a6b484ebc9a237897fba9 --- M doc/manuals/chapters/hardware.adoc A doc/manuals/images/icE1usb-e1_side.jpg A doc/manuals/images/icE1usb-usb_side.jpg 3 files changed, 19 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/hardware.adoc b/doc/manuals/chapters/hardware.adoc index 8055e64..0e129c2 100644 --- a/doc/manuals/chapters/hardware.adoc +++ b/doc/manuals/chapters/hardware.adoc @@ -19,7 +19,14 @@ PDF rendered schematics are available at https://git.osmocom.org/osmo-e1-hardware/plain/hardware/icE1usb/r1.0/icE1us… -=== Connectors +=== Connectors on E1 side + +image::images/icE1usb-e1_side.jpg[width=400,title="E1 side of icE1usb"] + +From left to right, there are the following connectors: + +* X5A: Primary E1 Port +* X5B: Secondary E1 Port ==== X5A and X5B: E1 Interface Connectors @@ -57,6 +64,17 @@ different pin-out. Particularly, you cannot use an Ethernet cross-over cable as an E1 cross-over! +=== Connectors on USB side + +image::images/icE1usb-usb_side.jpg[width=400,title="USB side of icE1usb"] + +From left to right, there are the following connectors: + +* X1: GPS Antenna Connector +* X2: Serial Console Connector +* X4: USB Connector +* X3: GPIO / Extension Connector + ==== X4: USB Connector The USB connector is a USB Type C connector. However, it only carries diff --git a/doc/manuals/images/icE1usb-e1_side.jpg b/doc/manuals/images/icE1usb-e1_side.jpg new file mode 100644 index 0000000..5bd274d --- /dev/null +++ b/doc/manuals/images/icE1usb-e1_side.jpg Binary files differ diff --git a/doc/manuals/images/icE1usb-usb_side.jpg b/doc/manuals/images/icE1usb-usb_side.jpg new file mode 100644 index 0000000..5d833d6 --- /dev/null +++ b/doc/manuals/images/icE1usb-usb_side.jpg Binary files differ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ifc382c762119b397dd9a6b484ebc9a237897fba9 Gerrit-Change-Number: 26949 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-e1-hardware[master]: icE1usb doc: Link to wiki page about iso USB issues
by laforge 18 Jan '22

18 Jan '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 ) Change subject: icE1usb doc: Link to wiki page about iso USB issues ...................................................................... icE1usb doc: Link to wiki page about iso USB issues Change-Id: Id5f555519d5e320570017178613c752591db4a2f --- M doc/manuals/chapters/firmware.adoc 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc index 1b440bd..5ae5fb1 100644 --- a/doc/manuals/chapters/firmware.adoc +++ b/doc/manuals/chapters/firmware.adoc @@ -185,7 +185,8 @@ activation of both icE1usb ports simultaneously. The XHCI controller firmware erroneously claims that there is insufficient bus bandwidth. However, the same icE1usb hardware/firmware works perfectly fine with -OHCI, UHCI and EHCI host controllers. +OHCI, UHCI and EHCI host controllers. See +https://osmocom.org/projects/e1-t1-adapter/wiki/Isochronous_USB_Issues for a user-maintained list of USB hosts / controllers and whether or not they work with two E1 ports. As most modern [PC] hardware has XHCI host controllers, you need to choose your hardware carefully if concurrent operation of both icE1usb -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id5f555519d5e320570017178613c752591db4a2f Gerrit-Change-Number: 26948 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-e1-hardware[master]: icE1usb doc: Add pictures of front and back side
by laforge 18 Jan '22

18 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 ) Change subject: icE1usb doc: Add pictures of front and back side ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ifc382c762119b397dd9a6b484ebc9a237897fba9 Gerrit-Change-Number: 26949 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jan 2022 20:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1-hardware[master]: icE1usb doc: Link to wiki page about iso USB issues
by laforge 18 Jan '22

18 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 ) Change subject: icE1usb doc: Link to wiki page about iso USB issues ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id5f555519d5e320570017178613c752591db4a2f Gerrit-Change-Number: 26948 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jan 2022 19:58:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1-hardware[master]: icE1usb doc: Link to wiki page about iso USB issues
by laforge 18 Jan '22

18 Jan '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 ) Change subject: icE1usb doc: Link to wiki page about iso USB issues ...................................................................... icE1usb doc: Link to wiki page about iso USB issues Change-Id: Id5f555519d5e320570017178613c752591db4a2f --- M doc/manuals/chapters/firmware.adoc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/48/26948/1 diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc index 1b440bd..5ae5fb1 100644 --- a/doc/manuals/chapters/firmware.adoc +++ b/doc/manuals/chapters/firmware.adoc @@ -185,7 +185,8 @@ activation of both icE1usb ports simultaneously. The XHCI controller firmware erroneously claims that there is insufficient bus bandwidth. However, the same icE1usb hardware/firmware works perfectly fine with -OHCI, UHCI and EHCI host controllers. +OHCI, UHCI and EHCI host controllers. See +https://osmocom.org/projects/e1-t1-adapter/wiki/Isochronous_USB_Issues for a user-maintained list of USB hosts / controllers and whether or not they work with two E1 ports. As most modern [PC] hardware has XHCI host controllers, you need to choose your hardware carefully if concurrent operation of both icE1usb -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id5f555519d5e320570017178613c752591db4a2f Gerrit-Change-Number: 26948 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-e1-hardware[master]: icE1usb doc: Add pictures of front and back side
by laforge 18 Jan '22

18 Jan '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 ) Change subject: icE1usb doc: Add pictures of front and back side ...................................................................... icE1usb doc: Add pictures of front and back side Closes: OS#5406 Change-Id: Ifc382c762119b397dd9a6b484ebc9a237897fba9 --- M doc/manuals/chapters/hardware.adoc A doc/manuals/images/icE1usb-e1_side.jpg A doc/manuals/images/icE1usb-usb_side.jpg 3 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/49/26949/1 diff --git a/doc/manuals/chapters/hardware.adoc b/doc/manuals/chapters/hardware.adoc index 8055e64..0e129c2 100644 --- a/doc/manuals/chapters/hardware.adoc +++ b/doc/manuals/chapters/hardware.adoc @@ -19,7 +19,14 @@ PDF rendered schematics are available at https://git.osmocom.org/osmo-e1-hardware/plain/hardware/icE1usb/r1.0/icE1us… -=== Connectors +=== Connectors on E1 side + +image::images/icE1usb-e1_side.jpg[width=400,title="E1 side of icE1usb"] + +From left to right, there are the following connectors: + +* X5A: Primary E1 Port +* X5B: Secondary E1 Port ==== X5A and X5B: E1 Interface Connectors @@ -57,6 +64,17 @@ different pin-out. Particularly, you cannot use an Ethernet cross-over cable as an E1 cross-over! +=== Connectors on USB side + +image::images/icE1usb-usb_side.jpg[width=400,title="USB side of icE1usb"] + +From left to right, there are the following connectors: + +* X1: GPS Antenna Connector +* X2: Serial Console Connector +* X4: USB Connector +* X3: GPIO / Extension Connector + ==== X4: USB Connector The USB connector is a USB Type C connector. However, it only carries diff --git a/doc/manuals/images/icE1usb-e1_side.jpg b/doc/manuals/images/icE1usb-e1_side.jpg new file mode 100644 index 0000000..5bd274d --- /dev/null +++ b/doc/manuals/images/icE1usb-e1_side.jpg Binary files differ diff --git a/doc/manuals/images/icE1usb-usb_side.jpg b/doc/manuals/images/icE1usb-usb_side.jpg new file mode 100644 index 0000000..5d833d6 --- /dev/null +++ b/doc/manuals/images/icE1usb-usb_side.jpg Binary files differ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ifc382c762119b397dd9a6b484ebc9a237897fba9 Gerrit-Change-Number: 26949 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: jenkins-jobs: add master build for opencm3 projects
by laforge 18 Jan '22

18 Jan '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26693 ) Change subject: jenkins-jobs: add master build for opencm3 projects ...................................................................... jenkins-jobs: add master build for opencm3 projects Change-Id: I95f84079478ce57d8d5c0cffd71bc67e1605e68e --- M jobs/master-builds.yml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 3b341ec..0c2be30 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -350,6 +350,9 @@ - simtrace2: cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' email: gerrit-log(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de + - osmo-opencm3-projects: + cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + email: gerrit-log(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de - osmo-e1d - osmo-cbc -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I95f84079478ce57d8d5c0cffd71bc67e1605e68e Gerrit-Change-Number: 26693 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2025

2024

2023

2022

gerrit-log