- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: gsm: Introduce helper rach_tx_integer_raw2val()
by pespin 26 Apr '22

26 Apr '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27945 to look at the new patch set (#3). Change subject: gsm: Introduce helper rach_tx_integer_raw2val() ...................................................................... gsm: Introduce helper rach_tx_integer_raw2val() Change-Id: I6ef085ee92b2064cb46fa5ec3ae98a0ca59ad599 --- M TODO-RELEASE M include/osmocom/gsm/gsm_utils.h M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.ok 4 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/27945/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ef085ee92b2064cb46fa5ec3ae98a0ca59ad599 Gerrit-Change-Number: 27945 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: gsm: Introduce helper rach_tx_integer_raw2val()
by pespin 26 Apr '22

26 Apr '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27945 to look at the new patch set (#2). Change subject: gsm: Introduce helper rach_tx_integer_raw2val() ...................................................................... gsm: Introduce helper rach_tx_integer_raw2val() Change-Id: I6ef085ee92b2064cb46fa5ec3ae98a0ca59ad599 --- M TODO-RELEASE M include/osmocom/gsm/gsm_utils.h M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.ok 4 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/27945/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ef085ee92b2064cb46fa5ec3ae98a0ca59ad599 Gerrit-Change-Number: 27945 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: gsm: Introduce helper rach_tx_integer_raw2val()
by pespin 26 Apr '22

26 Apr '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27945 ) Change subject: gsm: Introduce helper rach_tx_integer_raw2val() ...................................................................... gsm: Introduce helper rach_tx_integer_raw2val() Change-Id: I6ef085ee92b2064cb46fa5ec3ae98a0ca59ad599 --- M include/osmocom/gsm/gsm_utils.h M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.ok 3 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/27945/1 diff --git a/include/osmocom/gsm/gsm_utils.h b/include/osmocom/gsm/gsm_utils.h index 07b6a8b..e94ed71 100644 --- a/include/osmocom/gsm/gsm_utils.h +++ b/include/osmocom/gsm/gsm_utils.h @@ -152,6 +152,13 @@ const int tbl[4] = { 1, 2, 4, 7 }; return tbl[raw & 3]; } +static inline uint8_t rach_tx_integer_raw2val(uint8_t raw) { + const int tbl[6] = { 14, 16, 20, 25, 32, 50}; + raw &= 0x0f; + if (raw <= 9) + return raw + 3; + return tbl[raw - 10]; +} #define ARFCN_PCS 0x8000 #define ARFCN_UPLINK 0x4000 diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index cdccf53..2aceefa 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -1732,6 +1732,16 @@ VERIFY(rc, <, 0); } +static void test_rach_tx_integer_raw2val() +{ + unsigned int raw; + for (raw = 0; raw <= 0x0f; raw++) { + unsigned int val = rach_tx_integer_raw2val(raw); + printf("rach_tx_integer_raw2val(0x0%x): %u slots used to spread transmission\n", + raw, val); + } +} + int main(int argc, char **argv) { test_bearer_cap(); @@ -1750,6 +1760,7 @@ test_print_encoding(); test_range_encoding(); test_power_ctrl(); + test_rach_tx_integer_raw2val(); return EXIT_SUCCESS; } diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok index 52c4ea7..97bf083 100644 --- a/tests/gsm0408/gsm0408_test.ok +++ b/tests/gsm0408/gsm0408_test.ok @@ -791,3 +791,19 @@ Random range test: range 255, max num ARFCNs 22 Random range test: range 511, max num ARFCNs 18 Random range test: range 1023, max num ARFCNs 16 +rach_tx_integer_raw2val(0x00): 3 slots used to spread transmission +rach_tx_integer_raw2val(0x01): 4 slots used to spread transmission +rach_tx_integer_raw2val(0x02): 5 slots used to spread transmission +rach_tx_integer_raw2val(0x03): 6 slots used to spread transmission +rach_tx_integer_raw2val(0x04): 7 slots used to spread transmission +rach_tx_integer_raw2val(0x05): 8 slots used to spread transmission +rach_tx_integer_raw2val(0x06): 9 slots used to spread transmission +rach_tx_integer_raw2val(0x07): 10 slots used to spread transmission +rach_tx_integer_raw2val(0x08): 11 slots used to spread transmission +rach_tx_integer_raw2val(0x09): 12 slots used to spread transmission +rach_tx_integer_raw2val(0x0a): 14 slots used to spread transmission +rach_tx_integer_raw2val(0x0b): 16 slots used to spread transmission +rach_tx_integer_raw2val(0x0c): 20 slots used to spread transmission +rach_tx_integer_raw2val(0x0d): 25 slots used to spread transmission +rach_tx_integer_raw2val(0x0e): 32 slots used to spread transmission +rach_tx_integer_raw2val(0x0f): 50 slots used to spread transmission -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ef085ee92b2064cb46fa5ec3ae98a0ca59ad599 Gerrit-Change-Number: 27945 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: paging: Decouple retransmit period from regular worker interval
by pespin 26 Apr '22

26 Apr '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27944 to look at the new patch set (#2). Change subject: paging: Decouple retransmit period from regular worker interval ...................................................................... paging: Decouple retransmit period from regular worker interval Before this patch, on each BTS a 500ms timer was used to schedule some work, sending up to 20 paging requests verytime. This means, however, for an initial paging request it may take up to 500ms delay to be scheduled to the BTS, which is huge. While we still want to maintain this 500ms interval for retransmits, it doesn't make sense to wait that much for other cases. It's far better sending less requests (10 instead of 20) every half time (250ms instead of 500ms), since it will spread the load and paging more over time, allowing for other work to be done in the middle. Change-Id: I7a1297452cc4734b6ee8c38fb94cf32f38d57c3d --- M include/osmocom/bsc/paging.h M src/osmo-bsc/paging.c 2 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/27944/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7a1297452cc4734b6ee8c38fb94cf32f38d57c3d Gerrit-Change-Number: 27944 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-bts[master]: src/common/bts.c: set BTS_FEAT_CCN
by osmith 26 Apr '22

26 Apr '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27926 ) Change subject: src/common/bts.c: set BTS_FEAT_CCN ...................................................................... src/common/bts.c: set BTS_FEAT_CCN OsmoBSC assumed since If91d85331d402c3ab9c32b70c2c66cd7ba6ceb28 that OsmoBTS has CCN (NACC, Network Assisted Cell Change). With OsmoBSC Idf2d933aa8b03b1f708e56a08707fe6c620a97aa, instead of hardcoding some features for OsmoBTS in OsmoBSC, only the features reported by the BTS are used. Therefore report that BTS_FEATURE_CCN is supported in OsmoBTS. For previous OsmoBSC versions, this fixes the message: Get Attributes Response: reported feature 'CCN' is not supported, while we thought it is. Related: SYS#5922, OS#5538 Change-Id: Ic407e3be82afe61ed64b1cecf3dc94d2caff380a --- M src/common/bts.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/common/bts.c b/src/common/bts.c index cbd99db..a65bc92 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -382,6 +382,7 @@ /* features implemented in 'common', available for all models, * order alphabetically */ osmo_bts_set_feature(bts->features, BTS_FEAT_ABIS_OSMO_PCU); + osmo_bts_set_feature(bts->features, BTS_FEAT_CCN); osmo_bts_set_feature(bts->features, BTS_FEAT_DYN_TS_SDCCH8); osmo_bts_set_feature(bts->features, BTS_FEAT_ETWS_PN); osmo_bts_set_feature(bts->features, BTS_FEAT_IPV6_NSVC); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic407e3be82afe61ed64b1cecf3dc94d2caff380a Gerrit-Change-Number: 27926 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: src/common/bts.c: set BTS_FEAT_CCN
by fixeria 26 Apr '22

26 Apr '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27926 ) Change subject: src/common/bts.c: set BTS_FEAT_CCN ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic407e3be82afe61ed64b1cecf3dc94d2caff380a Gerrit-Change-Number: 27926 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 13:55:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: src/common/bts.c: set BTS_FEAT_CCN
by pespin 26 Apr '22

26 Apr '22

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27926 ) Change subject: src/common/bts.c: set BTS_FEAT_CCN ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic407e3be82afe61ed64b1cecf3dc94d2caff380a Gerrit-Change-Number: 27926 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 13:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: src/common/bts.c: set BTS_FEAT_CCN
by osmith 26 Apr '22

26 Apr '22

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27926 ) Change subject: src/common/bts.c: set BTS_FEAT_CCN ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Ack Ack. I've asked Philipp if this was not enabled on purpose in his patch https://gerrit.osmocom.org/c/osmo-bts/+/6642. He said that in theory it should be able to do EGPRS, but practically it didn't work, and suggested to leave this as-is by not reporting that EGPRS is supported for octphy. I've dropped the EGPRS/GPRS bits of this patch so now it only enables CCN. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic407e3be82afe61ed64b1cecf3dc94d2caff380a Gerrit-Change-Number: 27926 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 13:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: src/common/bts.c: set BTS_FEAT_CCN
by osmith 26 Apr '22

26 Apr '22

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/27926 to look at the new patch set (#2). Change subject: src/common/bts.c: set BTS_FEAT_CCN ...................................................................... src/common/bts.c: set BTS_FEAT_CCN OsmoBSC assumed since If91d85331d402c3ab9c32b70c2c66cd7ba6ceb28 that OsmoBTS has CCN (NACC, Network Assisted Cell Change). With OsmoBSC Idf2d933aa8b03b1f708e56a08707fe6c620a97aa, instead of hardcoding some features for OsmoBTS in OsmoBSC, only the features reported by the BTS are used. Therefore report that BTS_FEATURE_CCN is supported in OsmoBTS. For previous OsmoBSC versions, this fixes the message: Get Attributes Response: reported feature 'CCN' is not supported, while we thought it is. Related: SYS#5922, OS#5538 Change-Id: Ic407e3be82afe61ed64b1cecf3dc94d2caff380a --- M src/common/bts.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/26/27926/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic407e3be82afe61ed64b1cecf3dc94d2caff380a Gerrit-Change-Number: 27926 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc[master]: paging: Decouple retransmit period from regular worker interval
by pespin 26 Apr '22

26 Apr '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27944 ) Change subject: paging: Decouple retransmit period from regular worker interval ...................................................................... paging: Decouple retransmit period from regular worker interval Before this patch, on each BTS a 500ms timer was used to schedule some work, sending up to 20 paging requests verytime. This means, however, for an initial paging request it may take up to 500ms delay to be scheduled to the BTS, which is huge. While we still want to maintain this 500ms interval for retransmits, it doesn't make sense to wait that much for other cases. It's far better sending less requests (10 instead of 20) every half time (250ms instead of 500ms), since it will spread the load and paging more over time, allowing for other work to be done in the middle. Change-Id: I7a1297452cc4734b6ee8c38fb94cf32f38d57c3d --- M include/osmocom/bsc/paging.h M src/osmo-bsc/paging.c 2 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/27944/1 diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h index 2102e04..d9fd501 100644 --- a/include/osmocom/bsc/paging.h +++ b/include/osmocom/bsc/paging.h @@ -82,6 +82,8 @@ /* How often did we ask the BTS to page? */ int attempts; + /* Timestamp of last time the subscriber was paged */ + struct timespec last_attempt_ts; /* MSC that has issued this paging */ struct bsc_msc_data *msc; diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 8ce3508..c957f9f 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -59,7 +59,19 @@ void *tall_paging_ctx = NULL; /* How many paging requests to Tx on RSL at max before going back to main loop */ -#define MAX_PAGE_REQ_PER_ITER 20 +#define MAX_PAGE_REQ_PER_ITER 10 + +/* How often to attempt sending new paging requests (initial, not retrans): 250ms */ +static const struct timespec initial_period = { + .tv_sec = 0, + .tv_nsec = 250 * 1000 * 100, +}; + +/* Minimum period between retransmits of paging req to a subscriber: 500ms */ +static const struct timespec retrans_period = { + .tv_sec = 0, + .tv_nsec = 500 * 1000 * 100, +}; /* * Kill one paging request update the internal list... @@ -184,6 +196,7 @@ struct gsm_paging_request *request, *initial_request; unsigned int num_paged = 0; struct gsm_bts *bts = paging_bts->bts; + struct timespec now, retrans_ts; /* * Determine if the pending_requests list is empty and @@ -198,6 +211,8 @@ if (!bts->c0->rsl_link_primary) goto sched_next_iter; + osmo_clock_gettime(CLOCK_MONOTONIC, &now); + /* do while loop: Try send at most first MAX_PAGE_REQ_PER_ITER paging * requests (or before if there are no more available slots). Since * transmitted requests are re-appended at the end of the list, we check @@ -222,9 +237,23 @@ goto sched_next_iter; } + /* If we reach around back of the queue (retransmitions), check + * if time to retransmit has elapsed. Otherwise, wait until its + * time to retransmit. */ + if (request->attempts > 0) { + timespecadd(&request->last_attempt_ts, &retrans_period, &retrans_ts); + if (timespeccmp(&now, &retrans_ts, <)) { + struct timespec tdiff; + timespecsub(&retrans_ts, &now, &tdiff); + osmo_timer_schedule(&paging_bts->work_timer, tdiff.tv_sec, tdiff.tv_nsec / 1000); + return; + } + } + /* handle the paging request now */ page_ms(request); paging_bts->available_slots--; + request->last_attempt_ts = now; request->attempts++; num_paged++; @@ -236,7 +265,7 @@ /* Once done iterating, prepare next scheduling: */ sched_next_iter: - osmo_timer_schedule(&paging_bts->work_timer, 0, 500000); + osmo_timer_schedule(&paging_bts->work_timer, initial_period.tv_sec, initial_period.tv_nsec / 1000); } static void paging_worker(void *data) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7a1297452cc4734b6ee8c38fb94cf32f38d57c3d Gerrit-Change-Number: 27944 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2025

2024

2023

2022

gerrit-log