- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: abis_rsl: Use proper struct in rsl_paging_cmd
by pespin 03 May '22

03 May '22

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28000 to look at the new patch set (#2). Change subject: abis_rsl: Use proper struct in rsl_paging_cmd ...................................................................... abis_rsl: Use proper struct in rsl_paging_cmd Use the same one as used to decode the message in osmo-bts. This patch doesn't cause a change in logic since both headers are binary identical. Change-Id: Ideb863fdaedf77caac1a320de6696ba4f507a398 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/00/28000/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ideb863fdaedf77caac1a320de6696ba4f507a398 Gerrit-Change-Number: 28000 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc[master]: paging: Take into account extra delay of all paging groups in BSC queue
by pespin 03 May '22

03 May '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28002 ) Change subject: paging: Take into account extra delay of all paging groups in BSC queue ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28002/comment/c415e8c9_80b749a9 PS2, Line 671: GSM51_MFRAME_DURATION_us > is dividing GSM51_MFRAME_DURATION_us by n_pag_blocks intentional? Yes. we can send n_pag_block requests every GSM51_MFRAME_DURATION_us microseconds, so we do the following relation: npag_block/GSM51_MFRAME_DURATION_us = 1/time_us; time_us = 1*GSM51_MFRAME_DURATION_us/npag_block; That means we can send 1 paging req every GSM51_MFRAME_DURATION_us/n_pag_block. The (n_pag_blocks - 1) part is to do the integer ceiling of the resulting division. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib55f947c5d3490b27e1d08d39392992919512f9a Gerrit-Change-Number: 28002 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 May 2022 08:39:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: abis_rsl.c: Drop unused function
by pespin 03 May '22

03 May '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27999 ) Change subject: abis_rsl.c: Drop unused function ...................................................................... abis_rsl.c: Drop unused function Change-Id: I14457608aba799eccf9db6983d72fe0a5343be5c --- M src/osmo-bsc/abis_rsl.c 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index bacfa64..43c38e6 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -926,23 +926,6 @@ return rsl_data_request(msg, 0); } -int imsi_str2bcd(uint8_t *bcd_out, const char *str_in) -{ - int i, len = strlen(str_in); - - for (i = 0; i < len; i++) { - int num = str_in[i] - 0x30; - if (num < 0 || num > 9) - return -1; - if (i % 2 == 0) - bcd_out[i/2] = num; - else - bcd_out[i/2] |= (num << 4); - } - - return 0; -} - /* Chapter 8.5.6 */ struct msgb *rsl_imm_assign_cmd_common(struct gsm_bts *bts, uint8_t len, uint8_t *val) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I14457608aba799eccf9db6983d72fe0a5343be5c Gerrit-Change-Number: 27999 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: tests/acc: Remove unused var
by pespin 03 May '22

03 May '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27998 ) Change subject: tests/acc: Remove unused var ...................................................................... tests/acc: Remove unused var Change-Id: I1b56b4f8d3c3901cdf9a971e9ed95a6ebbbc1cca --- M tests/acc/acc_test.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c index 12124d3..1e78f73 100644 --- a/tests/acc/acc_test.c +++ b/tests/acc/acc_test.c @@ -33,9 +33,7 @@ static void clock_debug(char* str) { - struct timespec ts; struct timeval tv; - osmo_clock_gettime(CLOCK_MONOTONIC, &ts); osmo_gettimeofday(&tv, NULL); fprintf(stderr, "sys={%lu.%06lu}: %s\n", tv.tv_sec, tv.tv_usec, str); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b56b4f8d3c3901cdf9a971e9ed95a6ebbbc1cca Gerrit-Change-Number: 27998 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: tests: Order tests alphabetically
by pespin 03 May '22

03 May '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27997 ) Change subject: tests: Order tests alphabetically ...................................................................... tests: Order tests alphabetically Change-Id: Ic7507c90854a1c953f4c016b1b0e569bca570b37 --- M configure.ac M tests/Makefile.am M tests/testsuite.at 3 files changed, 24 insertions(+), 24 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index c4eac4a..3ff4524 100644 --- a/configure.ac +++ b/configure.ac @@ -230,14 +230,14 @@ src/utils/Makefile tests/Makefile tests/atlocal + tests/abis/Makefile tests/acc/Makefile - tests/gsm0408/Makefile tests/bsc/Makefile tests/codec_pref/Makefile - tests/abis/Makefile - tests/subscr/Makefile - tests/nanobts_omlattr/Makefile + tests/gsm0408/Makefile tests/handover/Makefile + tests/nanobts_omlattr/Makefile + tests/subscr/Makefile doc/Makefile doc/examples/Makefile doc/manuals/Makefile diff --git a/tests/Makefile.am b/tests/Makefile.am index 4421354..03ba212 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,12 +1,12 @@ SUBDIRS = \ + abis \ acc \ bsc \ codec_pref \ gsm0408 \ - abis \ - subscr \ - nanobts_omlattr \ handover \ + nanobts_omlattr \ + subscr \ $(NULL) # The `:;' works around a Bash 3.2 bug when the output is not writeable. diff --git a/tests/testsuite.at b/tests/testsuite.at index e7eb76b..9e3e614 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -1,19 +1,6 @@ AT_INIT AT_BANNER([Regression tests.]) -AT_SETUP([gsm0408]) -AT_KEYWORDS([gsm0408]) -cat $abs_srcdir/gsm0408/gsm0408_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [ignore]) -AT_CLEANUP - -AT_SETUP([bsc_subscr]) -AT_KEYWORDS([bsc_subscr]) -cat $abs_srcdir/subscr/bsc_subscr_test.ok > expout -cat $abs_srcdir/subscr/bsc_subscr_test.err > experr -AT_CHECK([$abs_top_builddir/tests/subscr/bsc_subscr_test], [], [expout], [experr]) -AT_CLEANUP - AT_SETUP([abis]) AT_KEYWORDS([abis]) cat $abs_srcdir/abis/abis_test.ok > expout @@ -38,10 +25,10 @@ AT_CHECK([$abs_top_builddir/tests/codec_pref/codec_pref_test], [], [expout], [ignore]) AT_CLEANUP -AT_SETUP([nanobts_omlattr]) -AT_KEYWORDS([nanobts_omlattr]) -cat $abs_srcdir/nanobts_omlattr/nanobts_omlattr_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/nanobts_omlattr/nanobts_omlattr_test], [], [expout], [ignore]) +AT_SETUP([gsm0408]) +AT_KEYWORDS([gsm0408]) +cat $abs_srcdir/gsm0408/gsm0408_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [ignore]) AT_CLEANUP AT_SETUP([handover_tests]) @@ -49,3 +36,16 @@ cat $abs_srcdir/handover/handover_tests.ok > expout AT_CHECK([$abs_srcdir/handover/handover_tests.sh $abs_srcdir/handover $abs_builddir/handover], [], [expout], [ignore]) AT_CLEANUP + +AT_SETUP([nanobts_omlattr]) +AT_KEYWORDS([nanobts_omlattr]) +cat $abs_srcdir/nanobts_omlattr/nanobts_omlattr_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/nanobts_omlattr/nanobts_omlattr_test], [], [expout], [ignore]) +AT_CLEANUP + +AT_SETUP([subscr]) +AT_KEYWORDS([subscr]) +cat $abs_srcdir/subscr/bsc_subscr_test.ok > expout +cat $abs_srcdir/subscr/bsc_subscr_test.err > experr +AT_CHECK([$abs_top_builddir/tests/subscr/bsc_subscr_test], [], [expout], [experr]) +AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic7507c90854a1c953f4c016b1b0e569bca570b37 Gerrit-Change-Number: 27997 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: paging: Take into account extra delay of all paging groups in BSC queue
by osmith 03 May '22

03 May '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28002 ) Change subject: paging: Take into account extra delay of all paging groups in BSC queue ...................................................................... Patch Set 2: (3 comments) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28002/comment/ec6097e3_a4b0e008 PS2, Line 347: reqs_before_same_pgroup (group vs pgroup inconsistent?) https://gerrit.osmocom.org/c/osmo-bsc/+/28002/comment/d333aade_292634ae PS2, Line 664: If don't "If we don't"? https://gerrit.osmocom.org/c/osmo-bsc/+/28002/comment/778c8680_352639a8 PS2, Line 671: GSM51_MFRAME_DURATION_us is dividing GSM51_MFRAME_DURATION_us by n_pag_blocks intentional? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib55f947c5d3490b27e1d08d39392992919512f9a Gerrit-Change-Number: 28002 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 May 2022 07:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: library/RSL_Types: allow omitting IEs in ts_RSL_IPA_CRCX
by fixeria 03 May '22

03 May '22

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27993 ) Change subject: library/RSL_Types: allow omitting IEs in ts_RSL_IPA_CRCX ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27993/comment/0a71eb99_9cf1… PS1, Line 7: library/RSL_Types: alow omitting IEs in ts_RSL_IPA_CRCX > allow Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7c36c3de1716968bccb07b03d2141d9abb3c175f Gerrit-Change-Number: 27993 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 23:50:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: library/RSL_Types: allow omitting IEs in ts_RSL_IPA_CRCX
by fixeria 03 May '22

03 May '22

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27993 to look at the new patch set (#2). Change subject: library/RSL_Types: allow omitting IEs in ts_RSL_IPA_CRCX ...................................................................... library/RSL_Types: allow omitting IEs in ts_RSL_IPA_CRCX Change-Id: I7c36c3de1716968bccb07b03d2141d9abb3c175f Related: OS#5242 --- M library/RSL_Types.ttcn 1 file changed, 36 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/27993/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7c36c3de1716968bccb07b03d2141d9abb3c175f Gerrit-Change-Number: 27993 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_450req_no_paging_load_ind
by fixeria 02 May '22

02 May '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27970 ) Change subject: bsc: Introduce test TC_paging_450req_no_paging_load_ind ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I787cba895f1cb6c5bfef95259bcf69b4291a9237 Gerrit-Change-Number: 27970 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 21:58:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: bts: Properly free ctr/stat when bts object is freed
by fixeria 02 May '22

02 May '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28003 ) Change subject: bts: Properly free ctr/stat when bts object is freed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id213e21cf9bfc5439021e459c22ba4704d8cae2b Gerrit-Change-Number: 28003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 21:56:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log