- gerrit-log - lists.osmocom.org

Change in docker-playground[master]: make/Makefile: allow overriding '-it' for target 'run'

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27143 ) Change subject: make/Makefile: allow overriding '-it' for target 'run' ...................................................................... make/Makefile: allow overriding '-it' for target 'run' Allocating a pseudo-TTY (-t, --tty) fails when 'run' is executed inside of a Jenkins or cron script. This change fixes ttcn3-bts-test, which invokes 'run' to fetch the config files. Change-Id: If22f682be4f004c5bb43e65098079a4f4fe6158d Fixes: If15461240f3037c142c176fc7da745a1701ae3f8 --- M alpine-lighttpd/Makefile M gr-gsm-master/Makefile M make/Makefile M nplab-m3ua-test/Makefile M nplab-sua-test/Makefile M open5gs-latest/Makefile M openbts-umts/Makefile M osmo-bsc-master/Makefile M osmo-bts-master/Makefile M osmo-gbproxy-latest/Makefile M osmo-gbproxy-master/Makefile M osmo-gerrit-libosmo/Makefile M osmo-ggsn-latest/Makefile M osmo-ggsn-master/Makefile M osmo-gsm-tester/Makefile M osmo-hlr-master/Makefile M osmo-hnbgw-master/Makefile M osmo-hnodeb-master/Makefile M osmo-mgw-master/Makefile M osmo-msc-master/Makefile M osmo-nitb-master/Makefile M osmo-pcu-master/Makefile M osmo-ran/Makefile M osmo-ran/split/ran-bsc_mgw/Makefile M osmo-ran/split/ran-bts_pcu/Makefile M osmo-ran/split/ran-trx-ipc/Makefile M osmo-ran/split/ran-trx-uhd/Makefile M osmo-remsim-latest/Makefile M osmo-remsim-master/Makefile M osmo-sgsn-master/Makefile M osmo-smlc-master/Makefile M osmo-stp-master/Makefile M sctp-test/Makefile M sigtran-tests/Makefile M systemd/Makefile M ttcn3-bsc-test-vamos/Makefile M ttcn3-bsc-test/Makefile M ttcn3-cbc-test/Makefile M ttcn3-hnodeb-test/Makefile M ttcn3-msc-test/Makefile M ttcn3-nitb-sysinfo/Makefile M ttcn3-pcap-client-test/Makefile M ttcn3-pcu-test/Makefile M ttcn3-sccp-test/Makefile M ttcn3-sgsn-test/Makefile M ttcn3-smlc-test/Makefile M ttcn3-stp-test/Makefile 47 files changed, 48 insertions(+), 45 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/alpine-lighttpd/Makefile b/alpine-lighttpd/Makefile index 27e1529..109875f 100644 --- a/alpine-lighttpd/Makefile +++ b/alpine-lighttpd/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network pdn --ip 172.20.0.10 --ip6 fd10:5741:8e20:0000::10 -v httpd-vol:/etc/lighttpd/lighttpd.conf.d --stop-signal SIGINT +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network pdn --ip 172.20.0.10 --ip6 fd10:5741:8e20:0000::10 -v httpd-vol:/etc/lighttpd/lighttpd.conf.d --stop-signal SIGINT include ../make/Makefile diff --git a/gr-gsm-master/Makefile b/gr-gsm-master/Makefile index b030a43..aece960 100644 --- a/gr-gsm-master/Makefile +++ b/gr-gsm-master/Makefile @@ -1,4 +1,5 @@ RUN_ARGS?= \ + -it --rm \ --privileged \ -v /dev/bus/usb:/dev/bus/usb diff --git a/make/Makefile b/make/Makefile index b2d344e..20733b0 100644 --- a/make/Makefile +++ b/make/Makefile @@ -38,6 +38,7 @@ OSMO_STP_BRANCH?=master OPEN5GS_BRANCH?=main BUILD_ARGS?= +RUN_ARGS?=-it UPSTREAM_DISTRO?=debian:bullseye DISTRO?=debian-bullseye @@ -167,4 +168,4 @@ run: - docker run $(RUN_ARGS) -it $(IMAGE) $(RUN_CMD) + docker run $(RUN_ARGS) $(IMAGE) $(RUN_CMD) diff --git a/nplab-m3ua-test/Makefile b/nplab-m3ua-test/Makefile index 0631fd3..1fc6815 100644 --- a/nplab-m3ua-test/Makefile +++ b/nplab-m3ua-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.7.2 +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.7.2 include ../make/Makefile diff --git a/nplab-sua-test/Makefile b/nplab-sua-test/Makefile index 273a334..db51491 100644 --- a/nplab-sua-test/Makefile +++ b/nplab-sua-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.6.3 +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.6.3 include ../make/Makefile diff --git a/open5gs-latest/Makefile b/open5gs-latest/Makefile index 95c99bb..0338f4f 100644 --- a/open5gs-latest/Makefile +++ b/open5gs-latest/Makefile @@ -1,5 +1,5 @@ DATA_DIR?=$(shell pwd) USER_ID?=$(shell id -u) -RUN_ARGS=-v $(DATA_DIR):/data --user $(USER_ID) --network host --rm +RUN_ARGS=-it --rm -v $(DATA_DIR):/data --user $(USER_ID) --network host include ../make/Makefile diff --git a/openbts-umts/Makefile b/openbts-umts/Makefile index b030a43..aece960 100644 --- a/openbts-umts/Makefile +++ b/openbts-umts/Makefile @@ -1,4 +1,5 @@ RUN_ARGS?= \ + -it --rm \ --privileged \ -v /dev/bus/usb:/dev/bus/usb diff --git a/osmo-bsc-master/Makefile b/osmo-bsc-master/Makefile index af827f6..ed16a7f 100644 --- a/osmo-bsc-master/Makefile +++ b/osmo-bsc-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.20 -v bsc-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.20 -v bsc-vol:/data include ../make/Makefile diff --git a/osmo-bts-master/Makefile b/osmo-bts-master/Makefile index 80ae1f3..0332b05 100644 --- a/osmo-bts-master/Makefile +++ b/osmo-bts-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.210 -v bts-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.210 -v bts-vol:/data include ../make/Makefile diff --git a/osmo-gbproxy-latest/Makefile b/osmo-gbproxy-latest/Makefile index 9e5fb05..ac24e7a 100644 --- a/osmo-gbproxy-latest/Makefile +++ b/osmo-gbproxy-latest/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.22 -v gbproxy-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.22 -v gbproxy-vol:/data include ../make/Makefile diff --git a/osmo-gbproxy-master/Makefile b/osmo-gbproxy-master/Makefile index 9e5fb05..ac24e7a 100644 --- a/osmo-gbproxy-master/Makefile +++ b/osmo-gbproxy-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.22 -v gbproxy-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.22 -v gbproxy-vol:/data include ../make/Makefile diff --git a/osmo-gerrit-libosmo/Makefile b/osmo-gerrit-libosmo/Makefile index b08f5c0..af68c2a 100644 --- a/osmo-gerrit-libosmo/Makefile +++ b/osmo-gerrit-libosmo/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--tmpfs /tmpfs:exec +RUN_ARGS?=-it --tmpfs /tmpfs:exec include ../make/Makefile diff --git a/osmo-ggsn-latest/Makefile b/osmo-ggsn-latest/Makefile index 0142467..d8c16fb 100644 --- a/osmo-ggsn-latest/Makefile +++ b/osmo-ggsn-latest/Makefile @@ -1,5 +1,5 @@ RUN_ARGS?= \ - --rm \ + -it --rm \ --cap-add=NET_ADMIN --device /dev/net/tun:/dev/net/tun \ --sysctl net.ipv6.conf.all.disable_ipv6=0 \ --sysctl net.ipv6.conf.all.forwarding=1 \ diff --git a/osmo-ggsn-master/Makefile b/osmo-ggsn-master/Makefile index 0142467..d8c16fb 100644 --- a/osmo-ggsn-master/Makefile +++ b/osmo-ggsn-master/Makefile @@ -1,5 +1,5 @@ RUN_ARGS?= \ - --rm \ + -it --rm \ --cap-add=NET_ADMIN --device /dev/net/tun:/dev/net/tun \ --sysctl net.ipv6.conf.all.disable_ipv6=0 \ --sysctl net.ipv6.conf.all.forwarding=1 \ diff --git a/osmo-gsm-tester/Makefile b/osmo-gsm-tester/Makefile index 03366a0..76107df 100644 --- a/osmo-gsm-tester/Makefile +++ b/osmo-gsm-tester/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --privileged --cap-add=NET_ADMIN --device /dev/net/tun:/dev/net/tun --network sigtran --ip 172.18.50.21 -v ogt-vol:/data +RUN_ARGS?=-it --rm --privileged --cap-add=NET_ADMIN --device /dev/net/tun:/dev/net/tun --network sigtran --ip 172.18.50.21 -v ogt-vol:/data include ../make/Makefile diff --git a/osmo-hlr-master/Makefile b/osmo-hlr-master/Makefile index 77d4f8b..d0d0b57 100644 --- a/osmo-hlr-master/Makefile +++ b/osmo-hlr-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.10 -v msc-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.10 -v msc-vol:/data include ../make/Makefile diff --git a/osmo-hnbgw-master/Makefile b/osmo-hnbgw-master/Makefile index 47c3999..cadd43d 100644 --- a/osmo-hnbgw-master/Makefile +++ b/osmo-hnbgw-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.170 -v hnbgw-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.170 -v hnbgw-vol:/data include ../make/Makefile diff --git a/osmo-hnodeb-master/Makefile b/osmo-hnodeb-master/Makefile index 47c3999..cadd43d 100644 --- a/osmo-hnodeb-master/Makefile +++ b/osmo-hnodeb-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.170 -v hnbgw-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.170 -v hnbgw-vol:/data include ../make/Makefile diff --git a/osmo-mgw-master/Makefile b/osmo-mgw-master/Makefile index dc9b67b..8ce072e 100644 --- a/osmo-mgw-master/Makefile +++ b/osmo-mgw-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.180 -v mgw-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.180 -v mgw-vol:/data include ../make/Makefile diff --git a/osmo-msc-master/Makefile b/osmo-msc-master/Makefile index 77d4f8b..d0d0b57 100644 --- a/osmo-msc-master/Makefile +++ b/osmo-msc-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.10 -v msc-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.10 -v msc-vol:/data include ../make/Makefile diff --git a/osmo-nitb-master/Makefile b/osmo-nitb-master/Makefile index 44dde23..e5ff25e 100644 --- a/osmo-nitb-master/Makefile +++ b/osmo-nitb-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.20 -v nitb-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.20 -v nitb-vol:/data include ../make/Makefile diff --git a/osmo-pcu-master/Makefile b/osmo-pcu-master/Makefile index 87350c2..6c9351e 100644 --- a/osmo-pcu-master/Makefile +++ b/osmo-pcu-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.211 -v pcu-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.211 -v pcu-vol:/data include ../make/Makefile diff --git a/osmo-ran/Makefile b/osmo-ran/Makefile index 80b1069..505dd43 100644 --- a/osmo-ran/Makefile +++ b/osmo-ran/Makefile @@ -1,2 +1,2 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.25.200 -v bsc-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.25.200 -v bsc-vol:/data include ../make/Makefile diff --git a/osmo-ran/split/ran-bsc_mgw/Makefile b/osmo-ran/split/ran-bsc_mgw/Makefile index 0239a23..1732b0a 100644 --- a/osmo-ran/split/ran-bsc_mgw/Makefile +++ b/osmo-ran/split/ran-bsc_mgw/Makefile @@ -1,2 +1,2 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.25.200 -v bsc-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.25.200 -v bsc-vol:/data include ../../../make/Makefile diff --git a/osmo-ran/split/ran-bts_pcu/Makefile b/osmo-ran/split/ran-bts_pcu/Makefile index 3d539d1..7d2397c 100644 --- a/osmo-ran/split/ran-bts_pcu/Makefile +++ b/osmo-ran/split/ran-bts_pcu/Makefile @@ -1,2 +1,2 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.25.201 -v bsc-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.25.201 -v bsc-vol:/data include ../../../make/Makefile diff --git a/osmo-ran/split/ran-trx-ipc/Makefile b/osmo-ran/split/ran-trx-ipc/Makefile index 1d99f06..509b9fc 100644 --- a/osmo-ran/split/ran-trx-ipc/Makefile +++ b/osmo-ran/split/ran-trx-ipc/Makefile @@ -1,2 +1,2 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.25.202 -v bsc-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.25.202 -v bsc-vol:/data include ../../../make/Makefile diff --git a/osmo-ran/split/ran-trx-uhd/Makefile b/osmo-ran/split/ran-trx-uhd/Makefile index 1d99f06..509b9fc 100644 --- a/osmo-ran/split/ran-trx-uhd/Makefile +++ b/osmo-ran/split/ran-trx-uhd/Makefile @@ -1,2 +1,2 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.25.202 -v bsc-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.25.202 -v bsc-vol:/data include ../../../make/Makefile diff --git a/osmo-remsim-latest/Makefile b/osmo-remsim-latest/Makefile index 2e0e850..9273a98 100644 --- a/osmo-remsim-latest/Makefile +++ b/osmo-remsim-latest/Makefile @@ -1,3 +1,3 @@ -#RUN_ARGS?=--rm --network sigtran --ip 172.18.0.210 -v bts-vol:/data +#RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.210 -v bts-vol:/data include ../make/Makefile diff --git a/osmo-remsim-master/Makefile b/osmo-remsim-master/Makefile index 2e0e850..9273a98 100644 --- a/osmo-remsim-master/Makefile +++ b/osmo-remsim-master/Makefile @@ -1,3 +1,3 @@ -#RUN_ARGS?=--rm --network sigtran --ip 172.18.0.210 -v bts-vol:/data +#RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.210 -v bts-vol:/data include ../make/Makefile diff --git a/osmo-sgsn-master/Makefile b/osmo-sgsn-master/Makefile index 6bbd766..53984b8 100644 --- a/osmo-sgsn-master/Makefile +++ b/osmo-sgsn-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.21 -v sgsn-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.21 -v sgsn-vol:/data include ../make/Makefile diff --git a/osmo-smlc-master/Makefile b/osmo-smlc-master/Makefile index af827f6..ed16a7f 100644 --- a/osmo-smlc-master/Makefile +++ b/osmo-smlc-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.20 -v bsc-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.20 -v bsc-vol:/data include ../make/Makefile diff --git a/osmo-stp-master/Makefile b/osmo-stp-master/Makefile index 3fcea34..00ffbb1 100644 --- a/osmo-stp-master/Makefile +++ b/osmo-stp-master/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.200 -v stp-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.200 -v stp-vol:/data include ../make/Makefile diff --git a/sctp-test/Makefile b/sctp-test/Makefile index 79a894e..f23042c 100644 --- a/sctp-test/Makefile +++ b/sctp-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm +RUN_ARGS?=-it --rm include ../make/Makefile diff --git a/sigtran-tests/Makefile b/sigtran-tests/Makefile index b7a6cb8..32250b0 100644 --- a/sigtran-tests/Makefile +++ b/sigtran-tests/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.18.0.3 +RUN_ARGS?=-it --rm --network sigtran --ip 172.18.0.3 include ../make/Makefile diff --git a/systemd/Makefile b/systemd/Makefile index 80b1069..505dd43 100644 --- a/systemd/Makefile +++ b/systemd/Makefile @@ -1,2 +1,2 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.25.200 -v bsc-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.25.200 -v bsc-vol:/data include ../make/Makefile diff --git a/ttcn3-bsc-test-vamos/Makefile b/ttcn3-bsc-test-vamos/Makefile index 913c072..b397e14 100644 --- a/ttcn3-bsc-test-vamos/Makefile +++ b/ttcn3-bsc-test-vamos/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.31.202 -v ggsn-test-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.31.202 -v ggsn-test-vol:/data include ../make/Makefile diff --git a/ttcn3-bsc-test/Makefile b/ttcn3-bsc-test/Makefile index cbcd544..b1b6459 100644 --- a/ttcn3-bsc-test/Makefile +++ b/ttcn3-bsc-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.2.202 -v ggsn-test-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.2.202 -v ggsn-test-vol:/data include ../make/Makefile diff --git a/ttcn3-cbc-test/Makefile b/ttcn3-cbc-test/Makefile index 34897fd..93bfac3 100644 --- a/ttcn3-cbc-test/Makefile +++ b/ttcn3-cbc-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.23.202 +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.23.202 include ../make/Makefile diff --git a/ttcn3-hnodeb-test/Makefile b/ttcn3-hnodeb-test/Makefile index ce2919e..991d941 100644 --- a/ttcn3-hnodeb-test/Makefile +++ b/ttcn3-hnodeb-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.33.202 -v ggsn-test-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.33.202 -v ggsn-test-vol:/data include ../make/Makefile diff --git a/ttcn3-msc-test/Makefile b/ttcn3-msc-test/Makefile index 7f46da4..2a5112c 100644 --- a/ttcn3-msc-test/Makefile +++ b/ttcn3-msc-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.20.202 -v ggsn-test-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.20.202 -v ggsn-test-vol:/data include ../make/Makefile diff --git a/ttcn3-nitb-sysinfo/Makefile b/ttcn3-nitb-sysinfo/Makefile index 7b2593b..19d5917 100644 --- a/ttcn3-nitb-sysinfo/Makefile +++ b/ttcn3-nitb-sysinfo/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.5.230 -v ttcn3-nitb-sysinfo-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.5.230 -v ttcn3-nitb-sysinfo-vol:/data include ../make/Makefile diff --git a/ttcn3-pcap-client-test/Makefile b/ttcn3-pcap-client-test/Makefile index 1c6de69..32fa2d7 100644 --- a/ttcn3-pcap-client-test/Makefile +++ b/ttcn3-pcap-client-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 include ../make/Makefile diff --git a/ttcn3-pcu-test/Makefile b/ttcn3-pcu-test/Makefile index b172280..a207496 100644 --- a/ttcn3-pcu-test/Makefile +++ b/ttcn3-pcu-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.1.202 -v pcu-test-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.1.202 -v pcu-test-vol:/data include ../make/Makefile diff --git a/ttcn3-sccp-test/Makefile b/ttcn3-sccp-test/Makefile index cbcd544..b1b6459 100644 --- a/ttcn3-sccp-test/Makefile +++ b/ttcn3-sccp-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.2.202 -v ggsn-test-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.2.202 -v ggsn-test-vol:/data include ../make/Makefile diff --git a/ttcn3-sgsn-test/Makefile b/ttcn3-sgsn-test/Makefile index f96cf22..8be872e 100644 --- a/ttcn3-sgsn-test/Makefile +++ b/ttcn3-sgsn-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--rm --network sigtran --ip 172.19.1.202 -v sgsn-test-vol:/data +RUN_ARGS?=-it --rm --network sigtran --ip 172.19.1.202 -v sgsn-test-vol:/data include ../make/Makefile diff --git a/ttcn3-smlc-test/Makefile b/ttcn3-smlc-test/Makefile index 34897fd..93bfac3 100644 --- a/ttcn3-smlc-test/Makefile +++ b/ttcn3-smlc-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.23.202 +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.23.202 include ../make/Makefile diff --git a/ttcn3-stp-test/Makefile b/ttcn3-stp-test/Makefile index cbcd544..b1b6459 100644 --- a/ttcn3-stp-test/Makefile +++ b/ttcn3-stp-test/Makefile @@ -1,3 +1,3 @@ -RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.2.202 -v ggsn-test-vol:/data +RUN_ARGS?=-it --rm --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.2.202 -v ggsn-test-vol:/data include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If22f682be4f004c5bb43e65098079a4f4fe6158d Gerrit-Change-Number: 27143 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: make/Makefile: allow overriding '-it' for target 'run'

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27143 ) Change subject: make/Makefile: allow overriding '-it' for target 'run' ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If22f682be4f004c5bb43e65098079a4f4fe6158d Gerrit-Change-Number: 27143 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Feb 2022 12:01:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in pysim[master]: ts_102_221: Implement proper parsing of EF.DIR

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27130 ) Change subject: ts_102_221: Implement proper parsing of EF.DIR ...................................................................... Patch Set 6: (1 comment) File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/27130/comment/19633b3f_a7ed3f42 PS6, Line 512: ApplicationLabel > the code actually works as expected, it is just pylint that complains about it. Good to know it works when passed to the metaclass (or whatever it's called). Then adding a special comment should do the trick (untested): class ApplicationTemplate(BER_TLV_IE, tag=0x61, '# pylint: disable=E0602' nested=[ ... ]) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I875eb49e1f0370428c2eae69af84f5483bd5b1fc Gerrit-Change-Number: 27130 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Feb 2022 11:56:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: make/Makefile: allow overriding '-it' for target 'run'

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27143 ) Change subject: make/Makefile: allow overriding '-it' for target 'run' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If22f682be4f004c5bb43e65098079a4f4fe6158d Gerrit-Change-Number: 27143 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 11:54:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in pysim[master]: ts_102_221: Implement proper parsing of EF.DIR

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27130 ) Change subject: ts_102_221: Implement proper parsing of EF.DIR ...................................................................... Patch Set 6: (1 comment) File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/27130/comment/6758db7c_7f1cdea0 PS6, Line 512: ApplicationLabel > So pylint complains that this variable is undefined: […] the code actually works as expected, it is just pylint that complains about it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I875eb49e1f0370428c2eae69af84f5483bd5b1fc Gerrit-Change-Number: 27130 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 11:45:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in pysim[master]: filesystem.py: Accept both a class or an instance as TLV._tlv member

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27140 ) Change subject: filesystem.py: Accept both a class or an instance as TLV._tlv member ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0a5ec2a860104ffe4524c647105a42505ac394d6 Gerrit-Change-Number: 27140 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Feb 2022 11:44:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in openbsc[master]: libbsc: fix potential null-dereference in abis_nm_perform_test()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/openbsc/+/27144 ) Change subject: libbsc: fix potential null-dereference in abis_nm_perform_test() ...................................................................... libbsc: fix potential null-dereference in abis_nm_perform_test() Change-Id: I93d816a20ba208e9fd32a1fc172a78ccd326e1ba Related: OS#5450 --- M openbsc/src/libbsc/abis_nm.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/openbsc/src/libbsc/abis_nm.c b/openbsc/src/libbsc/abis_nm.c index 922c2d5..c1e2b53 100644 --- a/openbsc/src/libbsc/abis_nm.c +++ b/openbsc/src/libbsc/abis_nm.c @@ -1993,6 +1993,8 @@ if (!msg) msg = nm_msgb_alloc(); + if (!msg) + return -ENOMEM; msgb_tv_push(msg, NM_ATT_AUTON_REPORT, auton_report); msgb_tv_push(msg, NM_ATT_TEST_NO, test_nr); -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/27144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I93d816a20ba208e9fd32a1fc172a78ccd326e1ba Gerrit-Change-Number: 27144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in openbsc[master]: libbsc: fix potential null-dereference in abis_nm_perform_test()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/27144 ) Change subject: libbsc: fix potential null-dereference in abis_nm_perform_test() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/27144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I93d816a20ba208e9fd32a1fc172a78ccd326e1ba Gerrit-Change-Number: 27144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 11:12:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: stats: sanitize tcp stat name identifiers

by iedemam

Attention is currently required from: daniel. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: sanitize tcp stat name identifiers ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Oh then I'd expect osmo_stat_item_group_set_name to already do some sanitizing, maybe that's not cor […] There is no sanitation in osmo_stat_item_group_set_name(). Locating it there ensures clean names but removes some of the flexibility in how you choose to sanitize the strings. Other uses of osmo_identifier_sanitize_buf() throughout the code specify various target and replacement chars. One issue I see when debugging this is that we are sanitizing on every call to fill_stats(), so every "stats-tcp interval" seconds, these group names are being set. I understand that can be useful if the connection changes but perhaps some optimization can be done. I want to keep this change as simple as possible though and I see myself expanding the scope already. :-) I'll leave it to Daniel to weigh in. What's the minimal change we can make to fix these bogus names. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 10:48:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: iedemam <michael(a)kapsulate.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in openbsc[master]: libbsc: fix potential null-dereference in abis_nm_perform_test()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/openbsc/+/27144 ) Change subject: libbsc: fix potential null-dereference in abis_nm_perform_test() ...................................................................... libbsc: fix potential null-dereference in abis_nm_perform_test() Change-Id: I93d816a20ba208e9fd32a1fc172a78ccd326e1ba Related: OS#5450 --- M openbsc/src/libbsc/abis_nm.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/44/27144/1 diff --git a/openbsc/src/libbsc/abis_nm.c b/openbsc/src/libbsc/abis_nm.c index 922c2d5..c1e2b53 100644 --- a/openbsc/src/libbsc/abis_nm.c +++ b/openbsc/src/libbsc/abis_nm.c @@ -1993,6 +1993,8 @@ if (!msg) msg = nm_msgb_alloc(); + if (!msg) + return -ENOMEM; msgb_tv_push(msg, NM_ATT_AUTON_REPORT, auton_report); msgb_tv_push(msg, NM_ATT_TEST_NO, test_nr); -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/27144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I93d816a20ba208e9fd32a1fc172a78ccd326e1ba Gerrit-Change-Number: 27144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log