Attention is currently required from: daniel.
iedemam has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27137 )
Change subject: stats: sanitize tcp stat name identifiers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Oh then I'd expect osmo_stat_item_group_set_name
to already do some sanitizing, maybe that's not cor […]
There is no sanitation
in osmo_stat_item_group_set_name(). Locating it there ensures clean names but removes some
of the flexibility in how you choose to sanitize the strings. Other uses of
osmo_identifier_sanitize_buf() throughout the code specify various target and replacement
chars.
One issue I see when debugging this is that we are sanitizing on every call to
fill_stats(), so every "stats-tcp interval" seconds, these group names are being
set. I understand that can be useful if the connection changes but perhaps some
optimization can be done.
I want to keep this change as simple as possible though and I see myself expanding the
scope already. :-) I'll leave it to Daniel to weigh in. What's the minimal change
we can make to fix these bogus names.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27137
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2
Gerrit-Change-Number: 27137
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Feb 2022 10:48:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <michael(a)kapsulate.com>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment