Attention is currently required from: daniel.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Oh then I'd expect osmo_stat_item_group_set_name to already do some sanitizing, maybe that's not cor […]

    There is no sanitation in osmo_stat_item_group_set_name(). Locating it there ensures clean names but removes some of the flexibility in how you choose to sanitize the strings. Other uses of osmo_identifier_sanitize_buf() throughout the code specify various target and replacement chars.

    One issue I see when debugging this is that we are sanitizing on every call to fill_stats(), so every "stats-tcp interval" seconds, these group names are being set. I understand that can be useful if the connection changes but perhaps some optimization can be done.

    I want to keep this change as simple as possible though and I see myself expanding the scope already. :-) I'll leave it to Daniel to weigh in. What's the minimal change we can make to fix these bogus names.

To view, visit change 27137. To unsubscribe, or for help writing mail filters, visit settings.