- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: improve encryption testing config TestHdlrEncrParams

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 ) Change subject: bsc: improve encryption testing config TestHdlrEncrParams ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > A bit hard to follow due to many changes in a single patch. Not going to block you though. thought of separating it but it seemed simple enough, sorry, next time -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6590ecf4a146dbed494d9d72f5a79441877e9010 Gerrit-Change-Number: 27234 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 16:06:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Makefile: Include hnbgw in SUBDIRS

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27240 ) Change subject: Makefile: Include hnbgw in SUBDIRS ...................................................................... Makefile: Include hnbgw in SUBDIRS Change-Id: I04616434cf8b5e67b67803040c3a03e4a0e3d182 --- M Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/27240/1 diff --git a/Makefile b/Makefile index 91c826c..1d5e670 100644 --- a/Makefile +++ b/Makefile @@ -24,6 +24,7 @@ gbproxy \ ggsn_tests \ hlr \ + hnbgw \ hnodeb \ mgw \ mme \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04616434cf8b5e67b67803040c3a03e4a0e3d182 Gerrit-Change-Number: 27240 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_srvcc_eutran_to_geran_src_sai

by osmith

Attention is currently required from: neels, pespin, fixeria, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27225 ) Change subject: bsc: Introduce test TC_srvcc_eutran_to_geran_src_sai ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I186b9b9436bf82bcd54ca348df1e5e4b6424ca6e Gerrit-Change-Number: 27225 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 14:18:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27222 ) Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Have a look at https://github.com/sysmocom/open5gs/blob/pespin/gtp1/lib/core/ogs-tlv-msg.h and .c it may give you ideas on how to define messages too. File src/libosmo-pfcp/gen__pfcp_ies_auto.c: https://gerrit.osmocom.org/c/osmo-upf/+/27222/comment/fb498e4a_c54511d7 PS1, Line 42: .dec_enc = "32be", we should have enums for this imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:34:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27221 ) Change subject: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It would be interesting to know how did you generate all this. By Hand? ope5ngs uses python scripts to parse types, messages, etc. from spec files. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I568b821e89007ed52eeefcdbcb6edd8052a8b5be Gerrit-Change-Number: 27221 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:30:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-upf[master]: libosmo-tlv: add auto dec/enc to/from structs

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27218 ) Change subject: libosmo-tlv: add auto dec/enc to/from structs ...................................................................... Patch Set 1: (2 comments) File include/osmocom/tlv/tlv_dec_enc.h: https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/e240fd96_68a88369 PS1, Line 60: OSMO_TLV_NESTED_IES_ORDERED_SAME = 0, This is not really clear. What's the difference between ORDERED_SAME and ORDERED? https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/421a08a9_42697e5d PS1, Line 135: * In this example, the nested IEs decode/encode to different goo sub structs depending on the tag value. goo? the table game? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I65de793105882a452124ee58adb0e58469e6e796 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-upf[master]: libosmo-tlv: add versatile TLV de- and encoder

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27217 ) Change subject: libosmo-tlv: add versatile TLV de- and encoder ...................................................................... Patch Set 1: (4 comments) File include/osmocom/tlv/tlv.h: https://gerrit.osmocom.org/c/osmo-upf/+/27217/comment/d52ae8f0_aa2de0ac PS1, Line 102: unsigned int tag; Isn't this duplicated in load_tl callback? File src/libosmo-tlv/tlv.c: https://gerrit.osmocom.org/c/osmo-upf/+/27217/comment/c5393a85_847a0f4b PS1, Line 256: static int t16l16v_load_tl(unsigned int *tag, size_t *len, const uint8_t **val, See my comment below for store_tl, it also applies here. https://gerrit.osmocom.org/c/osmo-upf/+/27217/comment/ce0d5b13_c0dcb6bf PS1, Line 266: static int t16l16v_store_tl(uint8_t *dst_data, size_t dst_data_avail, unsigned int tag, size_t len, From my experience after looking at open5gs TLV parser, these callbacks can avoided. As you can see, t16l16v_store_tl and t8l8v_store_tl are basically doing the same steps, but with different parameters. So you can avoid users needs to implement functions or this code calling functions pointers by simply storing some parameters in osmo_tlv_cfg: uint8_t tag_byte_len; uint8_t length_byte_len; You could also add tag_max_val = UINT16_MAX to the struct, and so on. Then this store_tl function can use all that anb become a static generic function. https://gerrit.osmocom.org/c/osmo-upf/+/27217/comment/a0a4f786_bd224b55 PS1, Line 275: osmo_store16be(tag, dst_data); You may want to also support setting instance in the API, to avoid API breakage in the future when we want to use it in more places. See open5gs lib/core/*tlv*.{c,h} for different types of TLVs. https://github.com/sysmocom/open5gs/blob/pespin/gtp1/lib/core/ogs-tlv.h#L32 The presence of Instance byte can also be then configured in tlv_config->instance_byte_len. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0fd00d9f288ffe13b7e67701f3e47073587404a Gerrit-Change-Number: 27217 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:06:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27233 ) Change subject: bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia94cc29bf66339ed782cb5101f3640f69cf73131 Gerrit-Change-Number: 27233 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:30:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: improve encryption testing config TestHdlrEncrParams

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 ) Change subject: bsc: improve encryption testing config TestHdlrEncrParams ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6590ecf4a146dbed494d9d72f5a79441877e9010 Gerrit-Change-Number: 27234 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:29:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by pespin

Attention is currently required from: laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File tests/ranap_rab_ass/ranap_rab_ass_test.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199/comment/6da2503f_7a26ba25 PS3, Line 305: ranap_rab_ass_req_ies_check_release(&message.msg.raB_AssignmentRequestIEs, 23); Same as previous patch. Add a test with a different ID not found. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log