Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28505 )
Change subject: gsm0408_test: do not return early in test_bearer_cap()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28505
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I39ac801e59ba56dfe3bcd4603b48f6fbf7cfb21c
Gerrit-Change-Number: 28505
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 03 Jul 2022 09:03:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin, fixeria, keith, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28509 )
Change subject: Change CC_CAUSE returned on unanswered MT Call
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
If I understand you / the situation correctly, then:
I think the main problem is that the RTP timer expires before the call control timer expires. Normally I think the call control timeout for MT not responding should be handled by call control, and not pre-empted by some RTP timer...
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 03 Jul 2022 09:03:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28509 )
Change subject: Change CC_CAUSE returned on unanswered MT Call
......................................................................
Patch Set 1:
(1 comment)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28509/comment/cf08d5bd_b34a264a
PS1, Line 281: (trans->cc.state == GSM_CSTATE_CALL_RECEIVED) ?
In adding this check, I should point out that I do not know what other CC state is possible when we reach this code, but in order to at least try not use the wrong cause for other situations, I decided to limit it to GSM_CSTATE_CALL_RECEIVED.
It might be better to know here if it was actually timer mgw X2 that expired. Maybe there is a way to know that, I don't see it glancing at what seems to be immediately available in trans or the msc_a. The timer expiration is quite some ways up the stack through various FSM callbacks. Or maybe there is another state we can check, for example, I thought to check for COMPLETE_LAYER3_PAGING_RESP. Even so, with those conditions in place, I don't think there is any way to know if the call was simply unanswered or if the MGW suffered some other problem?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sun, 03 Jul 2022 03:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/28509 )
Change subject: Change CC_CAUSE returned on unanswered MT Call
......................................................................
Change CC_CAUSE returned on unanswered MT Call
The timer "mgw X2" (RTP stream establishing timeout)
is set by default to 30 seconds.
When an MT call is ringing and remains unanswered, it
is this timer that will expire, and the call is terminated.
Up to now this results in a CC_CAUSE of Resource Unavailable
and if osmo-sip-connector is in use, the SIP agent will
get 503 Service Unavailable.
While "resource unavailable" may be technically correct, in
that the MGW did not return an rtp stream in time, returning
"No User Responding" (resulting in SIP 480) is probably a
more accurate description of what actually happened,
allowing the switch to inform the caller.
Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
---
M src/libmsc/gsm_04_08_cc.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/09/28509/1
diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 6562daa..9b7495f 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -278,6 +278,8 @@
if (trans->cc.mncc_initiated) {
mncc_release_ind(trans->net, trans, trans->callref,
GSM48_CAUSE_LOC_PRN_S_LU,
+ (trans->cc.state == GSM_CSTATE_CALL_RECEIVED) ?
+ GSM48_CC_CAUSE_USER_NOTRESPOND :
GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/28508
to look at the new patch set (#4).
Change subject: gsm48_ie: fix parsing of Bearer capability IE without octet 3a
......................................................................
gsm48_ie: fix parsing of Bearer capability IE without octet 3a
The testcase in gsm0408_test is still failing because the encoder
produces a different result (with octet 3a present). There is no
way to tell the encoder to use the implicit coding, and in general
this is not that critical, so we can live with that.
Change-Id: I722c168f01bffa915cb155eac234a796549d3762
---
M src/gsm/gsm48_ie.c
M tests/gsm0408/gsm0408_test.err
2 files changed, 20 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/28508/4
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28508
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I722c168f01bffa915cb155eac234a796549d3762
Gerrit-Change-Number: 28508
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/28508
to look at the new patch set (#3).
Change subject: gsm48_ie: fix parsing of Bearer capability IE without octet 3a
......................................................................
gsm48_ie: fix parsing of Bearer capability IE without octet 3a
The testcase in gsm0408_test is still failing because the encoder
produces a different result (with octet 3a present). There is no
way to tell the encoder to use the implicit coding, and in general
this is not that critical, so we can simple live with that.
Change-Id: I722c168f01bffa915cb155eac234a796549d3762
---
M src/gsm/gsm48_ie.c
M tests/gsm0408/gsm0408_test.err
2 files changed, 20 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/28508/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28508
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I722c168f01bffa915cb155eac234a796549d3762
Gerrit-Change-Number: 28508
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/28506
to look at the new patch set (#2).
Change subject: gsm0408_test: add a testcase for gsm48_decode_bearer_cap()
......................................................................
gsm0408_test: add a testcase for gsm48_decode_bearer_cap()
The new testcase contains a Bearer capability IE from Siemens S11E,
which does not use octet 3a (no extension bit set in octet 3).
gsm48_decode_bearer_cap() currently fails to parse it.
Change-Id: Ia19f3f6d80bc09ca3f8d39d35b148a0c0245141f
---
M tests/Makefile.am
M tests/gsm0408/gsm0408_test.c
A tests/gsm0408/gsm0408_test.err
M tests/gsm0408/gsm0408_test.ok
M tests/testsuite.at
5 files changed, 23 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/28506/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28506
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia19f3f6d80bc09ca3f8d39d35b148a0c0245141f
Gerrit-Change-Number: 28506
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset