- gerrit-log - lists.osmocom.org

[M] Change in osmo-ggsn[master]: gsn: fix coding style issue

by Jenkins Builder

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email ) Change subject: gsn: fix coding style issue ...................................................................... Patch Set 1: (27 comments) File gtp/gsn.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/4abf3f64_0949cd98?us… : PS1, Line 166: int (*cb)(struct sockaddr_in * peer)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/d82733e7_7a565165?us… : PS1, Line 173: int (*cb)(struct sockaddr_in * peer)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/3fc34f22_bf9005c4?us… : PS1, Line 180: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/2889a956_9bd563b7?us… : PS1, Line 188: int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb)(struct pdp_t * pdp)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/dd4ef6dc_07603fdd?us… : PS1, Line 196: struct pdp_t * pdp, void *cbp)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/4028e080_11b35779?us… : PS1, Line 203: int (*cb)(struct sockaddr_in * peer, uint8_t recovery)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/210a142a_606838ec?us… : PS1, Line 217: int (*cb_recovery2)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/fc4ea374_4954b053?us… : PS1, Line 218: struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/b38ce751_8c69bfdd?us… : PS1, Line 240: int (*cb_data_ind)(struct pdp_t * pdp, "foo * bar" should be "foo *bar" File include/osmocom/gtp/gsn.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/d818d9f6_786a28b2?us… : PS1, Line 100: int (*cb_delete_context)(struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/471e2576_054ff27f?us… : PS1, Line 101: int (*cb_create_context_ind)(struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/b21d5539_b56fd72a?us… : PS1, Line 103: int (*cb_unsup_ind)(struct sockaddr_in * peer); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/34459c95_57a5fc62?us… : PS1, Line 104: int (*cb_extheader_ind)(struct sockaddr_in * peer); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/b0b8a3e6_7c80dfd2?us… : PS1, Line 106: int (*cb_conf)(int type, int cause, struct pdp_t * pdp, void *cbp); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/65a56e84_96a2cf70?us… : PS1, Line 107: int (*cb_data_ind)(struct pdp_t * pdp, void *pack, unsigned len); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/dbc9c802_b30a83a7?us… : PS1, Line 108: int (*cb_recovery)(struct sockaddr_in * peer, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/444f081c_32a0fa4b?us… : PS1, Line 109: int (*cb_recovery2)(struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/8693f336_26b27853?us… : PS1, Line 109: int (*cb_recovery2)(struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/27ee80e7_b5aa5978?us… : PS1, Line 141: int (*cb_data_ind)(struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/f0770205_c73a95a6?us… : PS1, Line 150: int (*cb)(struct sockaddr_in * peer)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/0ba00e4e_24a6f6f0?us… : PS1, Line 153: int (*cb)(struct sockaddr_in * peer)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/f45cabcb_7f11d65c?us… : PS1, Line 156: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/ac9de58f_56d139b1?us… : PS1, Line 159: int (*cb)(int type, int cause, struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/7f4aa15b_e0ece7a2?us… : PS1, Line 163: int (*cb)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/2a0bb09f_4140379c?us… : PS1, Line 167: int (*cb)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/96920312_af5bc823?us… : PS1, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/73f86326_07f570ff?us… : PS1, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1d978ed32619b626e82aa70887ac94b82c4de378 Gerrit-Change-Number: 40436 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 04 Jun 2025 16:51:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 1 day

1
0
0 0

[M] Change in osmo-ggsn[master]: gsn: fix coding style issue

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email ) Change subject: gsn: fix coding style issue ...................................................................... gsn: fix coding style issue Remove a space between callbacks. Change-Id: I1d978ed32619b626e82aa70887ac94b82c4de378 --- M gtp/gsn.c M include/osmocom/gtp/gsn.h 2 files changed, 36 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/36/40436/1 diff --git a/gtp/gsn.c b/gtp/gsn.c index 782858f..6d6317c 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -163,21 +163,21 @@ } int gtp_set_cb_unsup_ind(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer)) + int (*cb)(struct sockaddr_in * peer)) { gsn->cb_unsup_ind = cb; return 0; } int gtp_set_cb_extheader_ind(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer)) + int (*cb)(struct sockaddr_in * peer)) { gsn->cb_extheader_ind = cb; return 0; } int gtp_set_cb_ran_info_relay_ind(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) + int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie)) { gsn->cb_ran_info_relay_ind = cb; return 0; @@ -185,22 +185,22 @@ /* API: Initialise delete context callback */ /* Called whenever a pdp context is deleted for any reason */ -int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb) (struct pdp_t * pdp)) +int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb)(struct pdp_t * pdp)) { gsn->cb_delete_context = cb; return 0; } int gtp_set_cb_conf(struct gsn_t *gsn, - int (*cb) (int type, int cause, - struct pdp_t * pdp, void *cbp)) + int (*cb)(int type, int cause, + struct pdp_t * pdp, void *cbp)) { gsn->cb_conf = cb; return 0; } int gtp_set_cb_recovery(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) + int (*cb)(struct sockaddr_in * peer, uint8_t recovery)) { gsn->cb_recovery = cb; return 0; @@ -214,7 +214,8 @@ * specs. */ int gtp_set_cb_recovery2(struct gsn_t *gsn, - int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) + int (*cb_recovery2)(struct sockaddr_in * peer, + struct pdp_t * pdp, uint8_t recovery)) { gsn->cb_recovery2 = cb_recovery2; return 0; @@ -228,16 +229,16 @@ * specs. */ int gtp_set_cb_recovery3(struct gsn_t *gsn, - int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, - struct pdp_t *pdp, uint8_t recovery)) + int (*cb_recovery3)(struct gsn_t *gsn, struct sockaddr_in *peer, + struct pdp_t *pdp, uint8_t recovery)) { gsn->cb_recovery3 = cb_recovery3; return 0; } int gtp_set_cb_data_ind(struct gsn_t *gsn, - int (*cb_data_ind) (struct pdp_t * pdp, - void *pack, unsigned len)) + int (*cb_data_ind)(struct pdp_t * pdp, + void *pack, unsigned len)) { gsn->cb_data_ind = cb_data_ind; return 0; diff --git a/include/osmocom/gtp/gsn.h b/include/osmocom/gtp/gsn.h index 006fdfd..fe1763e 100644 --- a/include/osmocom/gtp/gsn.h +++ b/include/osmocom/gtp/gsn.h @@ -97,17 +97,17 @@ struct osmo_timer_list queue_timer; /* internal queue_{req,resp} timer */ /* Call back functions */ - int (*cb_delete_context) (struct pdp_t *); - int (*cb_create_context_ind) (struct pdp_t *); + int (*cb_delete_context)(struct pdp_t *); + int (*cb_create_context_ind)(struct pdp_t *); int (*cb_update_context_ind)(struct pdp_t *pdp); - int (*cb_unsup_ind) (struct sockaddr_in * peer); - int (*cb_extheader_ind) (struct sockaddr_in * peer); - int (*cb_ran_info_relay_ind) (struct sockaddr_in *peer, union gtpie_member **ie); - int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); - int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); - int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); - int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); - int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, struct pdp_t *pdp, uint8_t recovery); + int (*cb_unsup_ind)(struct sockaddr_in * peer); + int (*cb_extheader_ind)(struct sockaddr_in * peer); + int (*cb_ran_info_relay_ind)(struct sockaddr_in *peer, union gtpie_member **ie); + int (*cb_conf)(int type, int cause, struct pdp_t * pdp, void *cbp); + int (*cb_data_ind)(struct pdp_t * pdp, void *pack, unsigned len); + int (*cb_recovery)(struct sockaddr_in * peer, uint8_t recovery); + int (*cb_recovery2)(struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); + int (*cb_recovery3)(struct gsn_t *gsn, struct sockaddr_in *peer, struct pdp_t *pdp, uint8_t recovery); /* Counters */ struct rate_ctr_group *ctrg; @@ -132,44 +132,44 @@ void *cbp); extern int gtp_set_cb_create_context_ind(struct gsn_t *gsn, - int (*cb_create_context_ind) (struct - pdp_t * - pdp)); + int (*cb_create_context_ind)(struct + pdp_t * + pdp)); extern int gtp_set_cb_update_context_ind(struct gsn_t *gsn, int (*cb_update_context_ind)(struct pdp_t *pdp)); extern int gtp_set_cb_data_ind(struct gsn_t *gsn, - int (*cb_data_ind) (struct pdp_t * pdp, + int (*cb_data_ind)(struct pdp_t * pdp, void *pack, unsigned len)); extern int gtp_set_cb_delete_context(struct gsn_t *gsn, - int (*cb_delete_context) (struct pdp_t * - pdp)); + int (*cb_delete_context)(struct pdp_t * + pdp)); /*extern int gtp_set_cb_create_context(struct gsn_t *gsn, int (*cb_create_context) (struct pdp_t* pdp)); */ extern int gtp_set_cb_unsup_ind(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer)); + int (*cb)(struct sockaddr_in * peer)); extern int gtp_set_cb_extheader_ind(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer)); + int (*cb)(struct sockaddr_in * peer)); extern int gtp_set_cb_ran_info_relay_ind(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); + int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie)); extern int gtp_set_cb_conf(struct gsn_t *gsn, - int (*cb) (int type, int cause, struct pdp_t * pdp, + int (*cb)(int type, int cause, struct pdp_t * pdp, void *cbp)); int gtp_set_cb_recovery(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer, + int (*cb)(struct sockaddr_in * peer, uint8_t recovery)) OSMO_DEPRECATED("Use gtp_set_cb_recovery2() instead, to obtain pdp ctx originating the recovery"); int gtp_set_cb_recovery2(struct gsn_t *gsn, - int (*cb) (struct sockaddr_in * peer, + int (*cb)(struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) OSMO_DEPRECATED("Use gtp_set_cb_recovery3() instead, to obtain gsn handling the recovery"); int gtp_set_cb_recovery3(struct gsn_t *gsn, - int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, + int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)); void gtp_clear_queues(struct gsn_t *gsn); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1d978ed32619b626e82aa70887ac94b82c4de378 Gerrit-Change-Number: 40436 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 1 day

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h ...................................................................... gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h Log macros will be used by multiple internal files. Change-Id: I3b59b067fc75d2ca2cbfe5cec010615e9b788923 --- M gtp/gsn.c M gtp/gtp.c M gtp/gtp_internal.h 3 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/35/40435/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3b59b067fc75d2ca2cbfe5cec010615e9b788923 Gerrit-Change-Number: 40435 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ggsn[master]: gtp: internal LOGP_WITH_ADDR macro: use pointer of peer

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40434?usp=email to look at the new patch set (#2). Change subject: gtp: internal LOGP_WITH_ADDR macro: use pointer of peer ...................................................................... gtp: internal LOGP_WITH_ADDR macro: use pointer of peer Using a pointer is more universal for the macro. Further the upcoming SGSN Context Req/Response/Ack code will use a peer pointer instead of the direct object. Change-Id: Iab11a8b07eb177c479e1920cd7fa8be2099a4b7b --- M gtp/gsn.c M gtp/gtp.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/34/40434/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iab11a8b07eb177c479e1920cd7fa8be2099a4b7b Gerrit-Change-Number: 40434 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

3 weeks, 1 day

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h

by Jenkins Builder

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email ) Change subject: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h ...................................................................... Patch Set 1: (3 comments) File gtp/gtp_internal.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/07e0669a_f60f54e0?us… : PS1, Line 10: #define GTP_LOGPKG(pri, peer, pack, len, fmt, args...) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/aef68bd9_439e558d?us… : PS1, Line 17: #define LOGP_WITH_ADDR(ss, level, peer, fmt, args...) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40435/comment/e68eeb72_c66b4670?us… : PS1, Line 19: inet_ntoa((peer)->sin_addr), ntohs((peer)->sin_port), \ please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3b59b067fc75d2ca2cbfe5cec010615e9b788923 Gerrit-Change-Number: 40435 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 04 Jun 2025 16:29:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 1 day

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email ) Change subject: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h ...................................................................... gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h Log macros will be used by multiple internal files. Change-Id: I3b59b067fc75d2ca2cbfe5cec010615e9b788923 --- M gtp/gsn.c M gtp/gtp.c M gtp/gtp_internal.h 3 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/35/40435/1 diff --git a/gtp/gsn.c b/gtp/gsn.c index 2409566..782858f 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -67,11 +67,6 @@ /* Error reporting functions */ -#define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ - LOGP(ss, level, "addr(%s:%d) " fmt, \ - inet_ntoa((addr)->sin_addr), ntohs((addr)->sin_port), \ - ##args) - static const struct rate_ctr_desc gsn_ctr_description[] = { [GSN_CTR_ERR_SOCKET] = { "err:socket", "Socket error" }, [GSN_CTR_ERR_READFROM] = { "err:readfrom", "readfrom() errors" }, diff --git a/gtp/gtp.c b/gtp/gtp.c index 3074776..369be0c 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -65,17 +65,6 @@ /* Error reporting functions */ -#define GTP_LOGPKG(pri, peer, pack, len, fmt, args...) \ - logp2(DLGTP, pri, __FILE__, __LINE__, 0, \ - "Packet from %s:%u, length: %d content: %s: " fmt, \ - inet_ntoa((peer)->sin_addr), ntohs((peer)->sin_port), \ - len, osmo_hexdump((const uint8_t *) pack, len), \ - ##args); - -#define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ - LOGP(ss, level, "addr(%s:%d) " fmt, \ - inet_ntoa((addr)->sin_addr), htons((addr)->sin_port), \ - ##args); TALLOC_CTX *tall_libgtp_ctx = NULL; diff --git a/gtp/gtp_internal.h b/gtp/gtp_internal.h index 06ba342..e3cbbca 100644 --- a/gtp/gtp_internal.h +++ b/gtp/gtp_internal.h @@ -3,6 +3,22 @@ #include <stdint.h> #include <talloc.h> +#include <arpa/inet.h> +#include <netinet/in.h> +#include <sys/socket.h> + +#define GTP_LOGPKG(pri, peer, pack, len, fmt, args...) \ +logp2(DLGTP, pri, __FILE__, __LINE__, 0, \ + "Packet from %s:%u, length: %d content: %s: " fmt, \ + inet_ntoa((peer)->sin_addr), ntohs((peer)->sin_port), \ + len, osmo_hexdump((const uint8_t *) pack, len), \ + ##args); + +#define LOGP_WITH_ADDR(ss, level, peer, fmt, args...) \ +LOGP(ss, level, "addr(%s:%d) " fmt, \ + inet_ntoa((peer)->sin_addr), ntohs((peer)->sin_port), \ + ##args); + uint64_t gtp_imsi_str2gtp(const char *str); extern TALLOC_CTX *tall_libgtp_ctx; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3b59b067fc75d2ca2cbfe5cec010615e9b788923 Gerrit-Change-Number: 40435 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ggsn[master]: gtp: internal LOGP_WITH_ADDR macro: use point of peer

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40434?usp=email ) Change subject: gtp: internal LOGP_WITH_ADDR macro: use point of peer ...................................................................... gtp: internal LOGP_WITH_ADDR macro: use point of peer Using a pointer is more universal for the macro. Further the upcoming SGSN Context Req/Response/Ack code will use a peer pointer instead of the direct object. Change-Id: Iab11a8b07eb177c479e1920cd7fa8be2099a4b7b --- M gtp/gsn.c M gtp/gtp.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/34/40434/1 diff --git a/gtp/gsn.c b/gtp/gsn.c index b8b752f..2409566 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -69,7 +69,7 @@ #define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ LOGP(ss, level, "addr(%s:%d) " fmt, \ - inet_ntoa((addr).sin_addr), ntohs((addr).sin_port), \ + inet_ntoa((addr)->sin_addr), ntohs((addr)->sin_port), \ ##args) static const struct rate_ctr_desc gsn_ctr_description[] = { @@ -453,7 +453,7 @@ if (bind(*fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { rate_ctr_inc2(gsn->ctrg, GSN_CTR_ERR_SOCKET); - LOGP_WITH_ADDR(DLGTP, LOGL_ERROR, addr, + LOGP_WITH_ADDR(DLGTP, LOGL_ERROR, &addr, "%s bind(fd=%d) failed: Error = %s\n", name, *fd, strerror(errno)); return -errno; diff --git a/gtp/gtp.c b/gtp/gtp.c index aaed27b..3074776 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -74,7 +74,7 @@ #define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ LOGP(ss, level, "addr(%s:%d) " fmt, \ - inet_ntoa((addr).sin_addr), htons((addr).sin_port), \ + inet_ntoa((addr)->sin_addr), htons((addr)->sin_port), \ ##args); TALLOC_CTX *tall_libgtp_ctx = NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iab11a8b07eb177c479e1920cd7fa8be2099a4b7b Gerrit-Change-Number: 40434 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ggsn[master]: gtp.c: no-op: use ntohs instead of htons

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40433?usp=email ) Change subject: gtp.c: no-op: use ntohs instead of htons ...................................................................... gtp.c: no-op: use ntohs instead of htons Even the operation is the same, the sin_port is in network order. Change-Id: Iebb031debfa7706f0ab682c94492b37573ae918d --- M gtp/gsn.c M gtp/gtp.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/33/40433/1 diff --git a/gtp/gsn.c b/gtp/gsn.c index 7022212..b8b752f 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -69,7 +69,7 @@ #define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ LOGP(ss, level, "addr(%s:%d) " fmt, \ - inet_ntoa((addr).sin_addr), htons((addr).sin_port), \ + inet_ntoa((addr).sin_addr), ntohs((addr).sin_port), \ ##args) static const struct rate_ctr_desc gsn_ctr_description[] = { diff --git a/gtp/gtp.c b/gtp/gtp.c index 9f2d484..aaed27b 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -68,7 +68,7 @@ #define GTP_LOGPKG(pri, peer, pack, len, fmt, args...) \ logp2(DLGTP, pri, __FILE__, __LINE__, 0, \ "Packet from %s:%u, length: %d content: %s: " fmt, \ - inet_ntoa((peer)->sin_addr), htons((peer)->sin_port), \ + inet_ntoa((peer)->sin_addr), ntohs((peer)->sin_port), \ len, osmo_hexdump((const uint8_t *) pack, len), \ ##args); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40433?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iebb031debfa7706f0ab682c94492b37573ae918d Gerrit-Change-Number: 40433 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 1 day

1
0
0 0

[XL] Change in osmo-ggsn[master]: gtp: add support for SGSN Context Req/Resp/Ack

by lynxis lazus

Attention is currently required from: daniel, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email ) Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... Patch Set 11: (6 comments) File gtp/gtp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/8463873f_6e6ee15c?us… : PS11, Line 899: struct > Im surprised that the destination peer is not 'const'. […] Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/a57376db_706b878f?us… : PS11, Line 1134: int gtp_decode_pdp_ctx(const uint8_t *buf, unsigned int size, struct pdp_t *pdp, uint16_t *sapi) > I think the function could deserve some documentation as a comment [doxygen style or not] Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/eddf1ca0_005a917d?us… : PS11, Line 1273: int gtp_encode_pdp_ctx(uint8_t *buf, unsigned int size, const struct pdp_t *pdp, uint16_t sapi) > I think the function could deserve some documentation as a comment [doxygen style or not] Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/108ae602_a0116865?us… : PS11, Line 1403: LOGP(DLGTP, LOGL_NOTICE, > shouldn't we print some kind of context? Like which GSN peer (address) has sent us the message with […] Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/2cf5f4bb_a9a10cea?us… : PS11, Line 1410: "SGSN Context Response expected Sequence flag set. Flags %d\n", packet->flags); > shouldn't we print some kind of context? Like which GSN peer (address) has sent us the message with […] Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/ee9b8d06_77d3c7d6?us… : PS11, Line 1458: "SGSN Context Request expected only on GTPCv1: %u\n", version); > same here Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 16:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 weeks, 1 day

1
0
0 0

[S] Change in osmo-ggsn[master]: gtpie: make ies const for getter

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email ) Change subject: gtpie: make ies const for getter ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gtp/gtpie.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/40432/comment/e2e38284_992388a2?us… : PS1, Line 304: extern int gtpie_getie(union gtpie_member * const ie[], int type, int instance); > you can also consitfy the union pointer I guess? Should I? I'm unsure. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I43195314b1cf416a1f2fd4d3ddd48c4eee462b0b Gerrit-Change-Number: 40432 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 16:24:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log