- gerrit-log - lists.osmocom.org

[XS] Change in osmocom-bb[master]: layer23: gsm_mncc_names[]: fix whitespace in a string
by laforge 16 Mar '26

16 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42400?usp=email ) Change subject: layer23: gsm_mncc_names[]: fix whitespace in a string ...................................................................... layer23: gsm_mncc_names[]: fix whitespace in a string Change-Id: I93b5445db267985f3d8c53cde08ff28f166ae79c --- M src/host/layer23/src/mobile/gsm48_cc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c index 94b81cb..2a8823f 100644 --- a/src/host/layer23/src/mobile/gsm48_cc.c +++ b/src/host/layer23/src/mobile/gsm48_cc.c @@ -138,7 +138,7 @@ { MNCC_CALL_CONF_REQ, "MNCC_CALL_CONF_REQ" }, { MNCC_START_DTMF_REQ, "MNCC_START_DTMF_REQ" }, { MNCC_STOP_DTMF_REQ, "MNCC_STOP_DTMF_REQ" }, - { MNCC_HOLD_REQ, "MNCC_HOLD_REQ " }, + { MNCC_HOLD_REQ, "MNCC_HOLD_REQ" }, { MNCC_RETRIEVE_REQ, "MNCC_RETRIEVE_REQ" }, { MNCC_FRAME_RECV, "MNCC_FRAME_RECV" }, { MNCC_FRAME_DROP, "MNCC_FRAME_DROP" }, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I93b5445db267985f3d8c53cde08ff28f166ae79c Gerrit-Change-Number: 42400 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmocom-bb[master]: layer23: gsm48_sysinfo_dump(): remove unused print argument
by laforge 16 Mar '26

16 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42399?usp=email ) Change subject: layer23: gsm48_sysinfo_dump(): remove unused print argument ...................................................................... layer23: gsm48_sysinfo_dump(): remove unused print argument Change-Id: I0a26d5ac3183dc7ccb2e7d3d77ab41b58ad5b871 --- M src/host/layer23/src/common/sysinfo.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index 1046e78..42fab5f 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -312,7 +312,7 @@ if (s->t3212) print(priv, "T3212 = %d sec.\n", s->t3212); else - print(priv, "T3212 = disabled\n", s->t3212); + print(priv, "T3212 = disabled\n"); /* channel description */ if (s->h) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0a26d5ac3183dc7ccb2e7d3d77ab41b58ad5b871 Gerrit-Change-Number: 42399 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: l1s_tch_{cmd,resp}(): fix misspelled FACCH
by laforge 16 Mar '26

16 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42396?usp=email ) Change subject: firmware/layer1: l1s_tch_{cmd,resp}(): fix misspelled FACCH ...................................................................... firmware/layer1: l1s_tch_{cmd,resp}(): fix misspelled FACCH Change-Id: I85646a8a0b37478ca517407fcca92d0b89d6aaca --- M src/target/firmware/layer1/prim_tch.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/target/firmware/layer1/prim_tch.c b/src/target/firmware/layer1/prim_tch.c index 1bc842b..7fe6d74 100644 --- a/src/target/firmware/layer1/prim_tch.c +++ b/src/target/firmware/layer1/prim_tch.c @@ -236,7 +236,7 @@ /* FACCH/F: B0(0...7),B1(4...11),B2(8...11,0...3) (mod 13) */ facch_rx_now = ((rx_time.fn % 13) % 4) == 3; } else { - /* FAACH/H: See GSM 05.02 Clause 7 Table 1of9 */ + /* FACCH/H: See GSM 05.02 Clause 7 Table 1of9 */ uint8_t t2_norm = rx_time.t2 - tch_sub; facch_rx_now = (t2_norm == 15) || (t2_norm == 23) || @@ -411,7 +411,7 @@ /* FACCH/F: B0(0...7),B1(4...11),B2(8...11,0...3) */ facch_tx_now = ((l1s.next_time.fn % 13) % 4) == 3; } else { - /* FAACH/H: See GSM 05.02 Clause 7 Table 1of9 */ + /* FACCH/H: See GSM 05.02 Clause 7 Table 1of9 */ uint8_t t2_norm = l1s.next_time.t2 - tch_sub; facch_tx_now = (t2_norm == 23) || (t2_norm == 6) || -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I85646a8a0b37478ca517407fcca92d0b89d6aaca Gerrit-Change-Number: 42396 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: l1a_rach_compl(): fix copy-pasted comment
by laforge 16 Mar '26

16 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42397?usp=email ) Change subject: firmware/layer1: l1a_rach_compl(): fix copy-pasted comment ...................................................................... firmware/layer1: l1a_rach_compl(): fix copy-pasted comment Change-Id: I8000218836bcb58946db48184360f821617dc93f --- M src/target/firmware/layer1/prim_rach.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/firmware/layer1/prim_rach.c b/src/target/firmware/layer1/prim_rach.c index 580131e..bb8c4f2 100644 --- a/src/target/firmware/layer1/prim_rach.c +++ b/src/target/firmware/layer1/prim_rach.c @@ -106,7 +106,7 @@ SCHED_END_SET() }; -/* Asynchronous completion handler for FB detection */ +/* Asynchronous completion handler for RACH detection */ static void l1a_rach_compl(__unused enum l1_compl c) { struct msgb *msg; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8000218836bcb58946db48184360f821617dc93f Gerrit-Change-Number: 42397 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: toa_input(): minor formatting fix
by laforge 16 Mar '26

16 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42398?usp=email ) Change subject: firmware/layer1: toa_input(): minor formatting fix ...................................................................... firmware/layer1: toa_input(): minor formatting fix Change-Id: Iba061badfde8a3875cbf7e7cd19ef89064922f57 --- M src/target/firmware/layer1/toa.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/target/firmware/layer1/toa.c b/src/target/firmware/layer1/toa.c index 4c9fff8..d6f37ff 100644 --- a/src/target/firmware/layer1/toa.c +++ b/src/target/firmware/layer1/toa.c @@ -54,7 +54,7 @@ { int valid = 1; - if (snr < TOA_SNR_THRESHOLD || offset < 0 || offset >31) + if (snr < TOA_SNR_THRESHOLD || offset < 0 || offset > 31) valid = 0; runavg_input(&toa_state.ravg, offset, valid); runavg_check_output(&toa_state.ravg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba061badfde8a3875cbf7e7cd19ef89064922f57 Gerrit-Change-Number: 42398 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_mmxx_msg_names[]: fix some strings
by laforge 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42402?usp=email ) Change subject: mobile: gsm48_mmxx_msg_names[]: fix some strings ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab3e249acc18057416a5c1fc00322b597df403d4 Gerrit-Change-Number: 42402 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 00:17:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_cc_tx_release_compl(): actually send the message
by laforge 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email ) Change subject: mobile: gsm48_cc_tx_release_compl(): actually send the message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 Gerrit-Change-Number: 42401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 00:17:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: layer23: gsm_mncc_names[]: fix whitespace in a string
by laforge 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42400?usp=email ) Change subject: layer23: gsm_mncc_names[]: fix whitespace in a string ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I93b5445db267985f3d8c53cde08ff28f166ae79c Gerrit-Change-Number: 42400 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 00:17:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: layer23: gsm48_sysinfo_dump(): remove unused print argument
by laforge 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42399?usp=email ) Change subject: layer23: gsm48_sysinfo_dump(): remove unused print argument ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0a26d5ac3183dc7ccb2e7d3d77ab41b58ad5b871 Gerrit-Change-Number: 42399 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 00:17:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: toa_input(): minor formatting fix
by laforge 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42398?usp=email ) Change subject: firmware/layer1: toa_input(): minor formatting fix ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba061badfde8a3875cbf7e7cd19ef89064922f57 Gerrit-Change-Number: 42398 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 00:16:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log